Re: [Kgdb-bugreport] ethernet debugging on 2.6.15 kernel

[Milind D. <mi...@li...>]

Checked this in with changes as told by Tom.
Files Changed
	- core-lite.patch
	- ChangeLog

-Milind
On Wed, 2006-06-21 at 08:19 -0700, Tom Rini wrote:
> On Wed, Jun 21, 2006 at 03:18:59PM +0530, Milind Dumbare wrote:
> 
> > Hi All,
> > 	Patch attached below replaces occurrences of checks of
> > pidhash_init_done by checks of last_pid. I have tested it on i386 and
> > x86_64 with both serial and ethernet. It works fine.
> 
> Looks good, but one problem that needs fixing before checkin:
> 
> > --- linux-2.6.16.20.orig/kernel/kgdb.c	2006-06-13 14:49:17.000000000 +0530
> > +++ linux-2.6.16.20/kernel/kgdb.c	2006-06-20 12:48:11.000000000 +0530
> > @@ -51,8 +51,7 @@
> >  
> >  
> >  extern int pid_max;
> > -extern int pidhash_init_done;
> > -
> > +extern int last_pid;
> 
> We should include <linux/sched.h> for this instead:
> $ grep -r last_pid ../linux-2.6.git/include/
> ../linux-2.6.git/include/linux/sched.h:extern int last_pid;
> 
> Thanks!
> 
-- 
...Milind
KGDB-PRO
http://www.linsyssoft.com/Kgdbpro.html