[Kgdb-bugreport] Re: [PATCH] Cache flushes and SMP work for MIPS

[Tom R. <tr...@ke...>]

On Thu, Dec 16, 2004 at 10:16:14AM -0800, Manish Lachwani wrote:

> Hi Tom,
> 
> Attached patch does the following two things for KGDB on MIPS:
> 
> 1. SMP changes
> 2. Removing the cache flushes from all places and putting one at the
> end of kgdb_handle_exception(). This approach works well on MIPS and I
> think should be tested on other arches as well.
> 
> As far as the SMP changes go, MIPS cannot roundup CPUs using an NMI approach. MIPS
> still has to use smp_call_function() for rounding CPUs. And because smp_call_function()
> relies on interrupt, the IRQs have to be enabled before kgdb_roundup_cpus().
> 
> Please review ...

As-is, this will break PPC32 (just tested).  I believe that on ppc32
we'll need to put back some cache flushing (in the arch-specific code,
so MIPS is OK).  I'll test once I verify my idea of a fix.

-- 
Tom Rini
http://gate.crashing.org/~trini/