[Kgdb-bugreport] [PATCH 10/15] powerpc: Replace hardcoded offset by BREAK_INSTR_SIZE
Status: Beta
Brought to you by:
jwessel
From: Jason W. <jas...@wi...> - 2010-07-30 19:18:02
|
From: Michal Simek <mo...@mo...> kgdb_handle_breakpoint checks the first arch_kgdb_breakpoint which is not known by gdb that's why is necessary jump over it. The jump lenght is equal to BREAK_INSTR_SIZE that's why is cleaner to use defined macro instead of hardcoded non-described offset. Signed-off-by: Michal Simek <mo...@mo...> Signed-off-by: Jason Wessel <jas...@wi...> CC: Benjamin Herrenschmidt <be...@ke...> CC: lin...@oz... --- arch/powerpc/kernel/kgdb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c index 82a7b22..7f61a3a 100644 --- a/arch/powerpc/kernel/kgdb.c +++ b/arch/powerpc/kernel/kgdb.c @@ -129,7 +129,7 @@ static int kgdb_handle_breakpoint(struct pt_regs *regs) return 0; if (*(u32 *) (regs->nip) == *(u32 *) (&arch_kgdb_ops.gdb_bpt_instr)) - regs->nip += 4; + regs->nip += BREAK_INSTR_SIZE; return 1; } -- 1.6.4.rc1 |