#5 KFocus crashes upon exit

[ville]

This bug is originally reported to ubuntu bug tracking system:
https://launchpad.net/distros/ubuntu/+source/kfocus/+bug/46050

Original Description:
"
Binary package hint: kfocus

KFocus crashes every time I exit the program.
"

[Thread debugging using libthread_db enabled]
[New Thread -1231911232 (LWP 7500)]
[KCrash handler]
#6 0x0805504a in QObject::metaObject ()
#7 0x080552e2 in QObject::metaObject ()
#8 0x0806154e in QPtrList<QListViewItem>::~QPtrList ()
#9 0x0806207e in QPtrList<QListViewItem>::~QPtrList ()
#10 0x08062310 in QPtrList<QListViewItem>::~QPtrList ()
#11 0xb7a53cdd in KMainWindow::closeEvent () from /usr/lib/libkdeui.so.4
#12 0xb7140a7c in QWidget::event () from /usr/lib/libqt-mt.so.3
#13 0xb721266e in QMainWindow::event () from /usr/lib/libqt-mt.so.3
#14 0xb709bdc6 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#15 0xb709cb46 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#16 0xb780dd7d in KApplication::notify () from /usr/lib/libkdecore.so.4
#17 0xb702d0ef in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#18 0xb713fa11 in QWidget::close () from /usr/lib/libqt-mt.so.3
#19 0x08063da3 in QPtrList<QListViewItem>::~QPtrList ()
#20 0x080684ed in QWidget::setGeometry ()
#21 0xb7105e29 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#22 0xb71068c4 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#23 0xb79dc8a7 in KAction::activated () from /usr/lib/libkdeui.so.4
#24 0xb7a12674 in KAction::slotActivated () from /usr/lib/libkdeui.so.4
#25 0xb7a2dd96 in KAction::slotPopupActivated () from /usr/lib/libkdeui.so.4
#26 0xb7a2e04b in KAction::qt_invoke () from /usr/lib/libkdeui.so.4
#27 0xb7105e29 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#28 0xb7498e1a in QSignal::signal () from /usr/lib/libqt-mt.so.3
#29 0xb71235a0 in QSignal::activate () from /usr/lib/libqt-mt.so.3
#30 0xb722aebd in QPopupMenu::mouseReleaseEvent () from /usr/lib/libqt-mt.so.3
#31 0xb79e84e7 in KPopupMenu::mouseReleaseEvent () from /usr/lib/libkdeui.so.4
#32 0xb71405fd in QWidget::event () from /usr/lib/libqt-mt.so.3
#33 0xb709bdc6 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#34 0xb709c350 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#35 0xb780dd7d in KApplication::notify () from /usr/lib/libkdecore.so.4
#36 0xb702d15d in QApplication::sendSpontaneousEvent ()
from /usr/lib/libqt-mt.so.3
#37 0xb7028558 in QETWidget::translateMouseEvent ()
from /usr/lib/libqt-mt.so.3
#38 0xb7026cf1 in QApplication::x11ProcessEvent () from /usr/lib/libqt-mt.so.3
#39 0xb7040473 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#40 0xb70b48b7 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#41 0xb70b47da in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#42 0xb709a8d5 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#43 0x08064764 in QPtrList<QListViewItem>::~QPtrList ()
#44 0xb6966ea2 in __libc_start_main () from /lib/tls/i686/cmov/libc.so.6
#45 0x08054181 in ?? ()

I've found that attached patch fixes this problem:
--- kfocus-1.0.2/kfocus/kfocus.cpp.orig 2006-12-18 20:28:05.000000000 +0200
+++ kfocus-1.0.2/kfocus/kfocus.cpp 2006-12-18 20:25:15.000000000 +0200
@@ -396,7 +396,7 @@
KMainWindow* w;
if(memberList)
{
- for(w=memberList->first(); w!=0; w=memberList->first())
+ for(w=memberList->first(); w!=0; w=memberList->next())
{
// only close the window if the closeEvent is accepted. If the user presses
// Cancel on the saveModified() dialog, the window and the application stay open.

[ville]

patch