Re: [Kernow] TransformControllerImpl depends on TabbedView (logic vs/ UI)

[Florent G. <dar...@ya...>]

  Hi

> >   4/ TabbedView split

> >   Wait for a "go".  Actually I think I will make the change,
> > without commit it.  Once it will be finished (in a few days),
> > you'll be free to have a concrete look and see then what we
> > would do with it.

> Hmmm, I'm still not sure about this one.  With all of these
> changes, I have full confidence in you :) If you think its the
> right think to do, then I'm happy for you commit the changes.

> However - and this is very important - I don't want to have to
> undo and any changes you make, or fix any bugs caused by the
> changes - so as long as the changes are not rushed, then I'm
> happy.

  Yes, sure.  I carefully inspected any commit to merge them into
the new TabbedView.  I am quite confident I didn't miss anything
that was commited into the repository yet, but I will double
check the code.

  Actually, I worked on copies of the classes, with other name.
This is quite dirty (I should have used a new package), but you
can download them and add them to your project, that won't break
anything.

  The files are at:

    http://www.fgeorges.org/tmp/net.sf.kernow-split-tabbedview.zip

  Just copy the files in the archive in 'transform' and 'ui'
packages, then you should be able to change the main class to
'net.sf.kernow.transform.TransformControllerImpl_1' in
<righ-click on project> -> Properties -> Run -> Main Class to
test them.

  Have a look at the TabbedPart_* classes and forms.  They are
really more readable.  The common interface can be saw by looking
at the parts source code, even if it doesn't exist yet.

  This is preliminary work.  So if you agree to use them and
confirm you don't have pending changes related to those classes,
I will adapt existing classes accordingly and rename the parts
with some more happy names.

  There is some Javadoc to write too, and unit tests.

  Do you have any comment?

  Regards,

--drkm






















      _____________________________________________________________________________ 
Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail