Re: [Kernow] Admin: feature tracker rights (was: Pending issues and little TODOs)

[Florent G. <dar...@ya...>]

Andrew Welch wrote:

> Ok, you should now be on the list.

  That worked, thanks!

  I saw you have commited changes to FileUtil and TabbedView.  Great! 
I have two little comments.  In FileUtilTest you use:

    assertTrue(xxx.equals(yyy))

I suggest to change to assertEquals() as this is far more convenient in
case of failure (the values are displayed in the IDE).  And in
TabbedView you changed the instanciation of Source and Result, except
in runValidateXML and runCheckedSchema.  I suggest to use FileUtil too
there.

  Are you ok with those two little changes?

  Regards,

--drkm





















      _____________________________________________________________________________ 
Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail