Menu

#109 Second outline?

open
nobody
enhancement (7)
2024-01-23
2023-09-21
Anonymous
No

Originally created by: Akselmo

Hi, this effect is pretty cool and I like using it.

However, I would like to have two outlines:

  1. The inner one is the current one
  2. Outer 1px width outline that is just plain black

This screenshot is from Aurorae theme I made from Arc Dark Aurorae, but basically this is the effect I am after

image

I actually wouldn't mind implementing this! However, I have no idea where to even begin. I don't really understand where the outline is drawn in the shader code, and I don't have much experience on shaders in the first place.

So if anyone could point me in right direction, I could implement it and make a setting for it, then contribute upstream, if this is a feature you're interested in having :) Even if not, I wouldn't mind making the effect for myself.

Thanks!

Discussion

  • Anonymous

    Anonymous - 2023-09-23

    Originally posted by: matinlotfali

    I like this very much!
    You are absolutely right that the code is documented very poorly. So before we begin on this, as I already mentioned in another pull request [#101], I should add documentation on the current implementation and enable others to contribute more effectively.

     
  • Anonymous

    Anonymous - 2023-09-23

    Originally posted by: Akselmo

    Sounds good to me, I have time to work on this whenever.

     
  • Anonymous

    Anonymous - 2023-12-17

    Originally posted by: matinlotfali

    @Akselmo I added a lot of comments for you in [#121]

     
  • Anonymous

    Anonymous - 2023-12-17

    Originally posted by: Akselmo

    Thanks, will give it a looksie!

     
  • Anonymous

    Anonymous - 2024-01-23

    Originally posted by: SATYADAHAL

    @Akselmo any progress on second outline?

     
  • Anonymous

    Anonymous - 2024-01-23

    Originally posted by: Akselmo

    Sorry ive been so busy i forgot. I could try this on weekend possibly but cant promise anything. If someone else wants to make this, go right ahead :)

     

Log in to post a comment.

MongoDB Logo MongoDB