When the blur effect is enabled, there is a tiny corner bug on the bottom of the screen. I'm unsure why that's the case, but it seems like the kcorners bug from all the way back.
I confirm that I sometimes see that on a terminal with blurred background.
I don't know how to fix this. I will be needing some assistance to figure it out.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
let me look into how the kcorners bug fix worked, but from what I've read from various sources and an educated guess, it is due to the blur affect still interpreting the window size prior to applying the shader.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Apparently the "Korner Bug" fix was either removed or broken in new Plasma versions, there was a merge request for an API to add the feature and that feature would had also addressed the lack of blur on morphing windows(Magic lamp and Woobly) but in the end nothing happened, I would suggest to bring that up to the KDE devs and see if there could be a possible solution. So far the only solution I can see is if it's implemented at the Application Style level(Fork breeze, Lightly or even Klassy) and implement it there. The Korner bug is "fixed" at the Decoration Style level but not at the Application Style level.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I know it would add complexities to the code, but probably this can help. What if it were possible to become the blur plugin and control its radius from the same plugin that controls the borders?
One more thing to note: if selected no borders on a custom theme the corners go away. I think this might have something to do with the blur shader and borders somehow?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@levy-deng I am applying the rounding shader on all windows with plasma decoration. If a window comes with no decoration, you can add the window to the inclusion list in settings. The feature is added recently in the master branch.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yep! Issue is resolved. need to have the border rule set to no borders.On Jan 22, 2024, at 9:54 AM, Matin Lotfaliei @.***> wrote:
Is this issue resolved in the latest releases?
@levy-deng @RomanKode
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
just thought i should heads up, on plasma 6 if you install the lightlyshaders plasma 6 branch, use the lightly shaders blur, disable the normal blur, and then enable this extension the korners bug is fixed. at least it would appear to be.
here's an example i made by putting text on the corners to make it obvious
compared to using normal blur
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Originally posted by: matinlotfali
I confirm that I sometimes see that on a terminal with blurred background.
I don't know how to fix this. I will be needing some assistance to figure it out.
Originally posted by: levy-deng
let me look into how the kcorners bug fix worked, but from what I've read from various sources and an educated guess, it is due to the blur affect still interpreting the window size prior to applying the shader.
Originally posted by: levy-deng
One detail to note: There is no bug if you use this shader with the breeze theme.
Originally posted by: matinlotfali
Can you post a screenshot?
Originally posted by: RomanKode
Apparently the "Korner Bug" fix was either removed or broken in new Plasma versions, there was a merge request for an API to add the feature and that feature would had also addressed the lack of blur on morphing windows(Magic lamp and Woobly) but in the end nothing happened, I would suggest to bring that up to the KDE devs and see if there could be a possible solution. So far the only solution I can see is if it's implemented at the Application Style level(Fork breeze, Lightly or even Klassy) and implement it there. The Korner bug is "fixed" at the Decoration Style level but not at the Application Style level.
Originally posted by: RomanKode
I know it would add complexities to the code, but probably this can help. What if it were possible to become the blur plugin and control its radius from the same plugin that controls the borders?
https://github.com/Alban-Boissard/kwin-effects-blur-respect-rounded-decorations
Originally posted by: levy-deng
One more thing to note: if selected no borders on a custom theme the corners go away. I think this might have something to do with the blur shader and borders somehow?
Originally posted by: matinlotfali
@levy-deng I am applying the rounding shader on all windows with plasma decoration. If a window comes with no decoration, you can add the window to the inclusion list in settings. The feature is added recently in the
masterbranch.Originally posted by: matinlotfali
Is this issue resolved in the latest releases?
@levy-deng @RomanKode
Originally posted by: levy-deng
Yep! Issue is resolved. need to have the border rule set to no borders.On Jan 22, 2024, at 9:54 AM, Matin Lotfaliei @.***> wrote:
Is this issue resolved in the latest releases?
@levy-deng @RomanKode
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
Originally posted by: RomanKode
No and it may never will, unless KDE Devs add a Kwin API to do so.
the Shadows(if they are big enough) can hide the Korner bug pretty well.
Originally posted by: RomanKode
Still has the Korner Bug, just that shadows hide it and this a recently compiled version of this effect.
This is what the dev of Lightlyshaders is doing for his Plasma 6 release of the effect.
https://github.com/a-parhom/LightlyShaders#plasma-6
Basically forking his own Blur effect to be included.
Originally posted by: queenbiscuit311
just thought i should heads up, on plasma 6 if you install the lightlyshaders plasma 6 branch, use the lightly shaders blur, disable the normal blur, and then enable this extension the korners bug is fixed. at least it would appear to be.
here's an example i made by putting text on the corners to make it obvious
compared to using normal blur
Originally posted by: matinlotfali
@queenbiscuit311 It should be similar in KDE-Rounded-Corners