From: Jim B. <jim...@py...> - 2019-01-08 06:35:55
|
I agree with "better now (not perfect)"! Some more observations: 1. Java 9 is no longer supported, only Java 8 and Java 11, both of which are under long term support. 2. Java 11 removes javax.xml.bind, which we import from DatatypeConverter; fortunately we don't actually use! Commenting out two lines of source means trunk builds just fine on Java 11. 3. The key change that prevented Java 9 support from running, namely introspecting Java packages without using the rt.jar, now mostly works. In the regrtest, it still fails with importing Pattern from java.util.regex, not certain why; the two other imports tested in import_star_from_java.py work fine. 4. We do have some illegal access warnings from jnr.posix in terms of reflected fields, which we will have to look into at some point. Of course, this is just the usual encapsulation of Java that Java 9 introduced. 5. The other failing test in test_signal when run on JDK 11 is related to the change over to how signals are exposed. To summarize: [exec] 380 tests OK. [exec] 2 tests skipped: [exec] test_codecmaps_hk test_curses [exec] 2 tests failed: [exec] test_import_jy test_signal [exec] 2 fails unexpected: [exec] test_import_jy test_signal [exec] Result: 1 So this looks very close to me! Lots of incredibly hard work has gone into 2.7.2, it's time to get it out there. - Jim On Mon, Jan 7, 2019 at 1:19 PM Jeff Allen <ja...@fa...> wrote: > Thanks Adam. Mainly I thought we couldn't ship in such a shabby state on > Java 9. Better now (not perfect). -- J. > > Jeff Allen > > On 07/01/2019 10:55, Adam Burke wrote: > > I just checked out out the head for the first time in a while and regrtest > is green for me under Windows and Java 8. Great to see. > > <0.02 put in jar> > > From my (front-row?) spectator seat, I think more frequent patch releases > wouldn't hurt. It's been a fair while since 2.7.1. If the tests are green, > bugs have been fixed, and more stuff works in 2.7.2 than 2.7.1, I would > vote to ship. > > If the gradle stuff is working well enough to produce a jar, it could be > included and marked experimental? I'm sure it would be useful to projects > with dependencies on jython from maven or gradle projects. > > Obviously it would be good to announce the beta on the website though. > > Cheers > Adam > > _______________________________________________ > Jython-dev mailing list > Jyt...@li... > https://lists.sourceforge.net/lists/listinfo/jython-dev > |