Re: [Jython-dev] Building Jython3

[Jeff A. <ja...@fa...>]

On 31/05/2017 04:35, Jim Baker wrote:
> Thanks for kicking this specific discussion off. Some points:
>
> 1. We can switch to github now if we focus on Jython 3. I would 
> suggest using squash merges 
> (https://github.com/blog/2141-squash-your-commits 
> <https://github.com/blog/2141-squash-your-commits>). Then over time we 
> can adopt CPython core workflow.
I think this is good advice when we adopt the the git philosophy of 
topic-branching frequently committing. (We should.) With Mercurial, 
branching was discouraged (prohibited in the push, I think). Git gives 
us a lot of possibilities for squeezing out, at the PR stage or before, 
the noise-commits caused by merges and development choices later 
reverted. But let's only squash things together that belong together, 
and not be afraid to show key points on the journey to a feature if it 
aids others. This would all make reviewing a change easier.

I will continue using the CPython workflow (on the Jython 3 sandpit) 
experimentally. The missing part is the tools CPython created: labels, 
bots, and the linkage to the bug tracker.

> 2. We should bring in the Gradle build process that Darjus is working 
> on, and get that into Jython 3 as soon as possible.
I'd be happy to adopt that when it's ready, but would like to get on 
with code.

> 3. Once we finish pushing the 2.7 changes into Jython 3, hopefully 
> automated as Stefan suggests, we should backport going forward into 
> 2.7 (some changes will have to be made against 2.7 of course). Having 
> everything in https://github.com/jython/jython, with a branch for 2.7, 
> should simplify; and follows the CPython model. This means Jython 3 
> will take advantage of the planned history rewriting.
Good reminder. Playing back to be sure I've understood ... At present 
Jython 3 lives separately from the official Jython repository. The 
desirable state is as Jim says to replicate the CPython pattern 
(https://docs.python.org/devguide/devcycle.html#branches) on the 
official Jython repo (https://github.com/jython/jython), where if I've 
understood correctly, Jython 2.7 (current master) becomes a 2.7 branch, 
and we bring in the present state of https://github.com/jython/jython3 
as the new master. This would give us CI tests on Jython 3 that we 
presently lack.

I sense we might like to squash some of that into fewer "feature" 
commits, but _not_ down to one massive one. This sounds like hard 
labour, maybe too hard.

Not sure I understand the scope of "the intended history re-writing".

  Jeff

>
> On Tue, May 30, 2017 at 6:50 PM, fwi...@gm... 
> <mailto:fwi...@gm...> <fwi...@gm... 
> <mailto:fwi...@gm...>> wrote:
>
>     Starting a new thread, and including Isaiah Peng in case he has some
>     insights. Hi Isaiah! We are starting to discuss how to make the
>     Jython3 sandbox the main line for development after the Jython 2.7.1
>     release.
>
>     On Tue, May 30, 2017 at 6:39 AM, Jeff Allen <ja...@fa...
>     <mailto:ja...@fa...>> wrote:
>     > Part of me wants to pursue it, but not as much as making Jython
>     3 build.
>
>     I took a look, and made a couple of changes that get Jython3 building
>     for me, so the tip of https://github.com/jython/jython3
>     <https://github.com/jython/jython3> should now
>     build (I hope).
>
>     For me though, it does not run. I always get:
>
>     $ ./dist/bin/jython
>     Exception in thread "main"
>     Exception: java.lang.NullPointerException thrown from the
>     UncaughtExceptionHandler in thread "main"
>
>     Investigating further, the issue seems to have been introduced on Sept
>     19 in this commit, which unfortunately, is a biggish one:
>
>     """
>     commit 308a17a4e9972aa3814a358917ffbd25fd976864
>     Author: Isaiah Peng <is...@gm... <mailto:is...@gm...>>
>     Date:   Mon Sep 19 18:13:57 2016 +0200
>
>         rewrite zipimporter, detach from the shared importer abstract
>     class, since classpathpyimporter is currently not functional
>     """
>
>     The last commit that works on my machine is the one just before:
>
>     """
>     commit cfed7ce10083ca69f2cec19b9a73d78b60e13967
>     Author: Isaiah Peng <is...@gm... <mailto:is...@gm...>>
>     Date:   Mon Sep 19 15:24:04 2016 +0200
>
>         throw OSError for negative seek position
>     """
>
>     Hope this helps!
>
>     -Frank
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     _______________________________________________
>     Jython-dev mailing list
>     Jyt...@li...
>     <mailto:Jyt...@li...>
>     https://lists.sourceforge.net/lists/listinfo/jython-dev
>     <https://lists.sourceforge.net/lists/listinfo/jython-dev>
>
>