Menu
▾
▴
Re: [Jython-dev] 2.7.1rc, to infinity and beyond!
|
From: Jeff A. <ja...@fa...> - 2017-05-28 23:09:56
|
+1 on Stefan's suggestion that we simply start as we mean to go on with Jython 3 on GitHub. We still must choose a workflow and make it known. This might be a change of practice for those of us with direct commit rights, away from commit-then-review, to something based on PRs. I was always a bit surprised we did not have such a two-step process with Mercurial. Concerning identifying the value of individuals' contributions, I think we enter a minefield. It seems to be the Python way that we're all just names in a big flat acknowledgements file, however large or small our contribution. I saw this principle enunciated by Guido on python-dev. (Sorry, can't find it now.) Oh, now I look, it's loosely what the ACKS file itself says. I think it more practical to talk about what trust the project accords someone, which brings us back to workflow. On CPython there's an identified set of core developers who have the right (and are relied upon) to review others' contributions and commit them to the project repository -- being trusted to know their own competence. That is worth being clearer about for Jython, especially if someone has commit rights in practice but we don't expect them to review PRs/patches. On GitHub, some of us are members and others owners, but I don't know what is intended by that. There was some debate in CPython about the new workflow, whether code devs could review and accept their own work. I think there should normally be at least the opportunity for peer review if work is a large change ... something like I did for the 2.7.1 changes to the buffer interface and UTF-8 fix. In the unique case of the project lead, I believe Frank's status is a PSF appointment. I have seen that in documentation somewhere, but why not more prominently? Jeff Allen On 28/05/2017 21:45, James Mudd wrote: > Just a few comments from my point of view. > > I think moving to a Github based workflow will help to attract more > contributors to Jython. I just think more people are familiar with the > workflow, so it's less effort to get involved, even minor things like > having to sign up to bugs.jython.org <http://bugs.jython.org> might > put people off. Having said that I really hope more people get > involved. I have really enjoyed putting some work into Jython, and > have got to investigate some interesting bugs which has been really > fun. I think its a unique kind of project which is really interesting > to work on, and all the other contributors seem to be really friendly > and helpful. I hope to keep contributing in the future when time allows. > > Also thanks to Stefan for the comments, and the great discussion on > many of the bugs fixed over the last few months, as well as merging > many of my suggested patches. > > Looking forward to seeing the RC2, and hopefully soon after the final > release. > > James > > On 28 May 2017 at 19:11, Stefan Richthofer <Ste...@gm... > <mailto:Ste...@gm...>> wrote: > > > Agreed that getting on github will not be the most minor fix > > It occurred to me that this change actually aligns with our focus > shift to Jython 3. Maybe we can benefit from this by setting up > the new workflow only for Jython 3. Then it would be kind of a > reboot rather than a (potentially painful) migration. It would > naturaly sort out Jython 3 stuff from Jython 2 stuff. (We could > even consider to track Jython 3 issues on github and continue bjo > just for Jython 2.) Think about it. > > I also felt it was important to highlight Stefan's contribution to helping finalize 2.7.1 > > It's a great honor for me to be mentioned for this. Thank you very > much! > Looking at ACKNOWLEDGEMENTS I found that the file does not > explicitly display who is actually core-developing Jython right > now. Jeff, Jim, Darjus and Frank who are putting a lot of work > into Jython (or did so in the last years) are mentioned randomly > between all contributors, including persons with really minimal > contributions (don't get me wrong - every contribution is very > valuable!). While this is a very modest attitude I think the > (active) core-dev team should be explicitly named somewhere at the > beginning of the file, not lastly because users might need this > info to assess who to ask. Also - maybe I overlooked it - it is > nowhere stated that Frank is the project lead. This should be made > clear IMO. In case we decided to add such a section I'd suggest to > also mention James Mudd, at least for this release, because he > spent significantly more work on Jython than the average contributor. > > I'll get the soft release together this weekend. If there are no troubles, I'll get the hard RC2 out next > week. > > Looking forward to it! Thanks a lot. > > Best regards > -Stefan > *Gesendet:* Samstag, 27. Mai 2017 um 20:43 Uhr > *Von:* "fwi...@gm... <mailto:fwi...@gm...>" > <fwi...@gm... <mailto:fwi...@gm...>> > *An:* "Jim Baker" <jim...@py... <mailto:jim...@py...>> > *Cc:* "Jython Developers" <jyt...@li... > <mailto:jyt...@li...>> > *Betreff:* Re: [Jython-dev] 2.7.1rc, to infinity and beyond! > Great news, and amazing work everyone! I'll get the soft release > together this weekend. If there are no troubles, I'll get the hard > RC2 out next week. > On May 27, 2017 10:46, "Jim Baker" <jim...@py... > <mailto:jim...@py...>> wrote: > > Updated README to state RC2, plus fixed the typo. Thanks for > the feedback! > Agreed that getting on github will not be the most minor fix > (!), but it will be worth the effort. I do like Mercurial, and > very much appreciate the Hg team's help in moving Jython to > hg.python.org <http://hg.python.org> from Subversion. > Nonetheless, we found out in using Mercurial for the last 5 or > so years for Jython development that it didn't match our > development processes. It's both time to move on, and join > CPython upstream in its dev processes. > On Sat, May 27, 2017 at 5:07 AM, Adam Burke > <ada...@gm... <mailto:ada...@gm...>> wrote: > > I know I'm a lurker and not an active dev, but I'd prefer > the rc2 name as well, fwiw. > Cheers > Adam > On 27 May 2017 at 15:33, Jeff Allen <ja...@fa... > <mailto:ja...@fa...>> wrote: > > Excellent news! A lot has gone on between 2.7.0 and > 2.7.1. it's good to find we've all feel "done"at the > same time :) > > Small typo in your front page: "many others to thanks". > > I have a weak preference for calling it RC2 given > there was change after RC1. I think RC1 still > identifies a release, even if it was announced softly, > and what we have now is different. > > There's a bit more to cutting over to Git than > declaring it so. I've been watching CPython do this > with the corner of one eye. We will have both > bugs.jython.org <http://bugs.jython.org> and Git pull > requests for a while ... essentially forever. There > was some integration work (which we should steal, but > that depends, I suspect, on upgrading the tracker) and > conventions for how to refer to one from the other. It > was tough at points because of disagreement on how it > were best done, but we can just go along with their > conclusion. And s/bpo/bjo/. > > Jeff Allen > > On 27/05/2017 01:12, Jim Baker wrote: > > Agreed. It's time for putting this release > candidate out! I'm also glad about the timing, > because this mean Stefan has a great base to build > this summer's work on JyNI. I believe it's > technically RC1 still because the last RC was a > soft release, but Frank knows those specifics. > > I just ran the "yolk smoke test" from > http://bugs.jython.org/issue2570 > <http://bugs.jython.org/issue2570> > <http://bugs.jython.org/issue2570 > <http://bugs.jython.org/issue2570>> one last time, > just to make sure. Everything looks great! > > After this we can look into: > > 1. Finally get jython.org <http://jython.org> > <http://jython.org> revamped. I suggest the > simplicity — and modern look — of GitHub pages, > where we can host and then point jython.org > <http://jython.org> <http://jython.org> accordingly. > 2. Switch to the Gradle build that Darjus has been > working on > 3. Cut over to https://github.com/jython/jython > <https://github.com/jython/jython> with rewritten > history that removes extlib jars for a subsequent > release of 2.7.x, where x > 1 (maybe it's 12 for > the next release, but we can decide later). > > Lastly, I also felt it was important to highlight > Stefan's contribution to helping finalize 2.7.1, > as well as our appreciation to Google for > supporting him this summer for the Google Summer > of Code. First win for GSOC 2017 in other words. > Duly noted as of > https://hg.python.org/jython/rev/ab5434be88aa > <https://hg.python.org/jython/rev/ab5434be88aa> > > - Jim > > > > On May 26, 2017 7:24 PM, "Stefan Richthofer" > <Ste...@gm... > <mailto:Ste...@gm...> > <mailto:Ste...@gm... > <mailto:Ste...@gm...>>> wrote: > > > You can apply these updates to extlibs > Done as of > https://hg.python.org/jython/rev/f6b3ddbc1df8 > <https://hg.python.org/jython/rev/f6b3ddbc1df8> > <https://hg.python.org/jython/rev/f6b3ddbc1df8 > <https://hg.python.org/jython/rev/f6b3ddbc1df8>>. > From my point of view we can launch Jython > 2.7.1-RC2 now. > - no open PRs on github left > - no release blockers left apparently except #2487 > - all updates done as far as possible (python > std-lib will be next > challenge on this front) > So, I'd suggest everybody pushes last-minute > work and Frank hits > the release-button... :-) > What do you think? > Cheers! > -Stefan > > <snip> > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the > world's most > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot > _______________________________________________ > Jython-dev mailing list > Jyt...@li... > <mailto:Jyt...@li...> > https://lists.sourceforge.net/lists/listinfo/jython-dev > <https://lists.sourceforge.net/lists/listinfo/jython-dev> > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's > most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Jython-dev mailing list > Jyt...@li... > <mailto:Jyt...@li...> > https://lists.sourceforge.net/lists/listinfo/jython-dev > <https://lists.sourceforge.net/lists/listinfo/jython-dev> > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Jython-dev mailing list > Jyt...@li... > <mailto:Jyt...@li...> > https://lists.sourceforge.net/lists/listinfo/jython-dev > <https://lists.sourceforge.net/lists/listinfo/jython-dev> > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > <http://sdm.link/slashdot_______________________________________________> > Jython-dev mailing list Jyt...@li... > <mailto:Jyt...@li...> > https://lists.sourceforge.net/lists/listinfo/jython-dev > <https://lists.sourceforge.net/lists/listinfo/jython-dev> > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Jython-dev mailing list > Jyt...@li... > <mailto:Jyt...@li...> > https://lists.sourceforge.net/lists/listinfo/jython-dev > <https://lists.sourceforge.net/lists/listinfo/jython-dev> > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > Jython-dev mailing list > Jyt...@li... > https://lists.sourceforge.net/lists/listinfo/jython-dev |
