Re: [Jython-dev] Unicode user and file names (and v2.7.1)

[Jeff A. <ja...@fa...>]

If it messes up later tests then, until it can be fixed, I think the 
apparatus we have for excluding it applies. However, an extra test that 
would fail in that case might be a good addition.

BTW when diagnosing that kind of thing, I've found it useful that 
regrtest takes a list of tests on the command line, or in a file, and 
runs them in the order given (and as many times as given).

+1 for adding fine-grain skips as you intend, mentioning the most 
appropriate issue.

Jeff Allen

On 24/05/2017 17:27, Stefan Richthofer wrote:
> Hey Jeff, Frank
>
> thanks for coming back to this. However, I already helped myself to some extend.
> I wouldn't have asked if it was as simple as adding @skip. That's an option, but maybe not the "right" way (I should have been more specific).
>
> Specifically, the following tests should be excluded from test suite or moved to the very end (how to do that somewhat the "right" way?), because they potentially mess up guava internals such that later deadlocks can occur:
>
> test_json: Features its own test-suite, so not sure how well it is possible to exclude certain test files using regrtest.py, i.e. Lib/json/tests/test_recursion.py. Relevant tests to exclude from that file are:
>
> test_highly_nested_objects_decoding
> test_highly_nested_objects_encoding
> test_endless_recursion
>
>
> test_isinstance:
> test_subclass_recursion_limit
> test_isinstance_recursion_limit
>
> So, I'll just add @skipIf... to these, given that they are customized for Jython already, being in Lib. If you'd say we better exclude test_json and test_isinstance via regrtest.py or move them to the end, tell me...
> Maybe we'd better continue with this on bugtracker/#2536, if at all.
>
> Best
>
> -Stefan
>
>
>> Gesendet: Mittwoch, 24. Mai 2017 um 09:55 Uhr
>> Von: "Jeff Allen" <ja...@fa...>
>> An: jyt...@li...
>> Betreff: Re: [Jython-dev] Unicode user and file names (and v2.7.1)
>>
>> Sorry, I should have taken Stefan's hint.
>>
>> Yes, if we need to exclude a whole test, then there are lists in
>> regrtest.py as Frank says. This is quite a crude tool, perhaps best
>> suited to tests whose entire purpose is irrelevant to Jython or that
>> interfere with subsequent tests.
>>
>> It is better to skip individual tests as Frank also indicates. Some
>> tests really are not appropriate to Jython (mostly involving garbage
>> collection) because Jython is different and we're happy with it that
>> way. In other cases, it's a shortcoming of some kind and we should say
>> so in the skip message.
>>
>> Ideally, the skip message or a comment in regrtest.py where the
>> exclusion happens, according to the approach taken, links to an open
>> issue. That way, we haven't just silenced the alarm.
>>
>> Jeff
>>
>> Jeff Allen
>>
>> On 24/05/2017 01:35, fwi...@gm... wrote:
>>> On Tue, May 23, 2017 at 5:29 PM, fwi...@gm...
>>> <fwi...@gm...> wrote:
>>>> On Sat, May 20, 2017 at 5:00 PM, Stefan Richthofer
>>>> <Ste...@gm...> wrote:
>>>>> I'd like to have http://bugs.jython.org/issue2536 "fixed" by removing that
>>>>> infinite recursion test; maybe we could even close this annoying issue then.
>>>>> A new Jython release should have reliable test suite. However I don't know
>>>>> the best way to remove or blacklist a certain test.
>>>> I don't think I saw anyone answer this (but the thread is long so I
>>>> may have missed it) but if you look in regrtest.py you'll see a list
>>>> starting around line 880, with one section called 'java'. That's a
>>>> list of tests that are deliberately skipped. That list hasn't been
>>>> looked at in a long time, and I bet there are tests in there that
>>>> actually shouldn't get skipped anymore... but that's a whole different
>>>> can of worms :)
>>> Or if you are talking about a single test function and not a whole
>>> test file something like this decorating the particular test will
>>> work:
>>>
>>> @unittest.skipIf(test_support.is_jython, "Not a valid test for Jython")
>>>
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Jython-dev mailing list
>>> Jyt...@li...
>>> https://lists.sourceforge.net/lists/listinfo/jython-dev
>>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Jython-dev mailing list
>> Jyt...@li...
>> https://lists.sourceforge.net/lists/listinfo/jython-dev
>>