Re: [Jython-dev] Unicode user and file names (and v2.7.1)

[Jeff A. <ja...@fa...>]

Sorry, I should have taken Stefan's hint.

Yes, if we need to exclude a whole test, then there are lists in 
regrtest.py as Frank says. This is quite a crude tool, perhaps best 
suited to tests whose entire purpose is irrelevant to Jython or that 
interfere with subsequent tests.

It is better to skip individual tests as Frank also indicates. Some 
tests really are not appropriate to Jython (mostly involving garbage 
collection) because Jython is different and we're happy with it that 
way. In other cases, it's a shortcoming of some kind and we should say 
so in the skip message.

Ideally, the skip message or a comment in regrtest.py where the 
exclusion happens, according to the approach taken, links to an open 
issue. That way, we haven't just silenced the alarm.

Jeff

Jeff Allen

On 24/05/2017 01:35, fwi...@gm... wrote:
> On Tue, May 23, 2017 at 5:29 PM, fwi...@gm...
> <fwi...@gm...> wrote:
>> On Sat, May 20, 2017 at 5:00 PM, Stefan Richthofer
>> <Ste...@gm...> wrote:
>>> I'd like to have http://bugs.jython.org/issue2536 "fixed" by removing that
>>> infinite recursion test; maybe we could even close this annoying issue then.
>>> A new Jython release should have reliable test suite. However I don't know
>>> the best way to remove or blacklist a certain test.
>> I don't think I saw anyone answer this (but the thread is long so I
>> may have missed it) but if you look in regrtest.py you'll see a list
>> starting around line 880, with one section called 'java'. That's a
>> list of tests that are deliberately skipped. That list hasn't been
>> looked at in a long time, and I bet there are tests in there that
>> actually shouldn't get skipped anymore... but that's a whole different
>> can of worms :)
> Or if you are talking about a single test function and not a whole
> test file something like this decorating the particular test will
> work:
>
> @unittest.skipIf(test_support.is_jython, "Not a valid test for Jython")
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Jython-dev mailing list
> Jyt...@li...
> https://lists.sourceforge.net/lists/listinfo/jython-dev
>