[Jython-dev] Pull requests #36 and #38

[Stefan R. <Ste...@gm...>]

Hello everybody,

given that Jython 2.7.1 was delayed so long (actually we're about to reach the planned release date for 2.7.2) I'd like to merge the pull requests

https://github.com/jythontools/jython/pull/36

https://github.com/jythontools/jython/pull/38

before the release. I think there is no risk to introduce new issues with these changes, because they really do simple stuff or just add a function.

Regarding #36:
Given that there was no uname in Jython before there cannot be (sane*) code that could be affected even if my implementation was faulty.

* code might be conditioned on uname not existing, but I regard it a no-goal to preserve bug-compatibility to old versions


Regarding #38:
Changes only concern if-branches that don't apply to Jython anyway. Actually these branches could have been removed completely (stuff that is conditioned onto e.g. os.name == 'nt'). I did not remove them because Jython code might want to hack around with them, e.g. by actively setting os.name to some value != 'java' (code I doubt to exist anyway). However for JyNI I need these branches additionally secured by a check for != 'java' for reasons that go too far to explain here (I can give details on the use case on demand).
So semantically these checks don't change anything for Jython at all; they even reduce the number of failing checks a bit, as os.name != 'java' usually wraps an entire block of several checks for various platforms not applying to Jython-case.

If there are no concerns I would check these into Jython someday next week. Presumably these commits would allow me to drop the JyNI-specific ctypes python code and use the CPython-bundled ctypes entirely. #36 is also required for JyOpenGL.

Regards

Stefan