[Jython-checkins] SF.net SVN: jython:[6363] trunk/jython/Lib/test/test_cmd_line.py

[<pj...@us...>]

Revision: 6363
          http://jython.svn.sourceforge.net/jython/?rev=6363&view=rev
Author:   pjenvey
Date:     2009-05-22 02:41:04 +0000 (Fri, 22 May 2009)

Log Message:
-----------
don't use subprocess.call with PIPEs. it only wait()s -- without consuming
those pipes, their buffers can fill and cause a chatty child (like
test_run_module with the smaller Windows PIPE_BUF) to deadlock
fixes #1351

Modified Paths:
--------------
    trunk/jython/Lib/test/test_cmd_line.py

Modified: trunk/jython/Lib/test/test_cmd_line.py
===================================================================
--- trunk/jython/Lib/test/test_cmd_line.py	2009-05-21 06:04:58 UTC (rev 6362)
+++ trunk/jython/Lib/test/test_cmd_line.py	2009-05-22 02:41:04 UTC (rev 6363)
@@ -1,4 +1,4 @@
-
+import os
 import test.test_support, unittest
 import sys
 import popen2
@@ -18,8 +18,11 @@
     def exit_code(self, *args):
         cmd_line = [sys.executable]
         cmd_line.extend(args)
-        return subprocess.call(cmd_line, stdout=subprocess.PIPE,
-                                         stderr=subprocess.PIPE)
+        devnull = open(os.devnull, 'w')
+        result = subprocess.call(cmd_line, stdout=devnull,
+                                 stderr=subprocess.STDOUT)
+        devnull.close()
+        return result
 
     def test_directories(self):
         self.assertNotEqual(self.exit_code('.'), 0)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.