[Jython-checkins] SF.net SVN: jython:[5054] branches/asm/src/org/python/modules/thread/thread .java

[<zy...@us...>]

Revision: 5054
          http://jython.svn.sourceforge.net/jython/?rev=5054&view=rev
Author:   zyasoft
Date:     2008-08-02 21:35:23 +0000 (Sat, 02 Aug 2008)

Log Message:
-----------
Raise a ValueError if attempt to set thread.stack_size > 0 but <
32768. Fixes test_thread.

Modified Paths:
--------------
    branches/asm/src/org/python/modules/thread/thread.java

Modified: branches/asm/src/org/python/modules/thread/thread.java
===================================================================
--- branches/asm/src/org/python/modules/thread/thread.java	2008-08-02 19:51:15 UTC (rev 5053)
+++ branches/asm/src/org/python/modules/thread/thread.java	2008-08-02 21:35:23 UTC (rev 5054)
@@ -69,7 +69,13 @@
                 return stack_size;
             case 1:
                 long old_stack_size = stack_size;
-                stack_size = ((PyInteger)args[0].__int__()).getValue();
+                int proposed_stack_size = ((PyInteger)args[0].__int__()).getValue();
+                if (proposed_stack_size != 0 && proposed_stack_size < 32768) {
+                    // as specified by Python, Java quietly ignores what
+                    // it considers are too small
+                    throw Py.ValueError("size not valid: " + proposed_stack_size + " bytes");
+                }
+                stack_size = proposed_stack_size;
                 return old_stack_size;
             default:
                 throw Py.TypeError("stack_size() takes at most 1 argument (" + args.length + "given)");


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.