Very much agreed with Jeff's summary. And this commitment to high quality
with other fellow-minded contributors is what makes working on a project
like CPython, Jython, or the Python standard library such a worthwhile
longterm project for us. We figure out problems, write great code, and see
what others have worked on in their solutions. This process does work, and
it also allows us to contribute to this project as we have both time and
insight.
On Sat, Mar 31, 2018 at 11:17 AM, Jeff Allen <ja...@fa...> wrote:
> Those of us with commit rights help each other, and other contributors,
> achieve adequate quality, I would say. If you're at the committing end of
> this relationship, there is always the choice to be made between asking for
> change and quietly improving a contribution.
>
> There is a coding standard, and that's useful, but I think coding
> standards do not guarantee quality. So "compliance" is probably not the
> right concept to apply, and it's more a matter of taste and experience,
> which is not uniform. We're compliant in the other sense: willing to go
> along with each other's criticism (mostly). For example, I've had to admit
> at least once that I really should have written a test to go with my code,
> when someone else gently pointed that out. In a dispute, I believe we'd all
> give way to Frank and Jim as the longest-standing active contributors (and
> Frank is the PM), although I've got away with disagreeing when my reasons
> were good.
>
> This has worked without acrimony AFAIK during the time I've been
> contributing to Jython. I think this is a Python tradition. I found
> contributing to the main CPython dev-guide earlier this year to be an
> exercise in humility at times, but it improved my work and wasn't a bad
> experience overall.
>
> Jeff
>
> Jeff Allen
>
> On 30/03/2018 15:06, Patrick Palczewski wrote:
>
>>
>> hello,
>>
>> I wanted to ask this question: Does Jython currently have someone who
>> does compliance review, to reivew existing pr sib,submitted code to ensure
>> it complys with Jython or Python guidelines?
>>
>> --
>> /Patrick Palczewski/ *VRS# 818.208.2344*
>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Jython-dev mailing list
> Jyt...@li...
> https://lists.sourceforge.net/lists/listinfo/jython-dev
>
|
