From: Peter T. <pe...@us...> - 2002-06-26 23:39:50
|
Update of /cvsroot/jvcl/dev/restructured/source In directory usw-pr-cvs1:/tmp/cvs-serv9637/dev/restructured/source Modified Files: JvAutoSizeCompo.pas Log Message: Set Active to false as default, a few checks added Index: JvAutoSizeCompo.pas =================================================================== RCS file: /cvsroot/jvcl/dev/restructured/source/JvAutoSizeCompo.pas,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** JvAutoSizeCompo.pas 24 Jun 2002 10:27:25 -0000 1.1 --- JvAutoSizeCompo.pas 26 Jun 2002 23:39:47 -0000 1.2 *************** *** 50,54 **** destructor Destroy; override; published ! property Active: Boolean read FActive write FActive default True; end; --- 50,55 ---- destructor Destroy; override; published ! // (p3) default here should be false!!! ! property Active: Boolean read FActive write FActive; // default true; end; *************** *** 60,69 **** begin inherited; ! FActive := True; ! FForm := TForm(GetParentForm(TControl(AOwner))); ! FOldWidth := FForm.Width; ! FOldHeight := FForm.Height; ! FResize := FForm.OnResize; ! FForm.OnResize := Resize; end; {**************************************************} --- 61,74 ---- begin inherited; ! // (p3) dangerous: can create problems without user being aware ! // FActive := True; ! FForm := GetParentForm(TControl(AOwner)) as TForm; ! if FForm <> nil then ! begin ! FOldWidth := FForm.Width; ! FOldHeight := FForm.Height; ! FResize := FForm.OnResize; ! FForm.OnResize := Resize; ! end; end; {**************************************************} *************** *** 73,76 **** --- 78,82 ---- if FForm <> nil then FForm.OnResize := nil; + FForm := nil; inherited; end; *************** *** 82,87 **** CompIndex: Integer; begin ! if FActive then begin if (FOldWidth <> 0) and (FOldHeight <> 0) then begin --- 88,97 ---- CompIndex: Integer; begin ! if FForm = nil then ! FForm := GetParentForm(Owner as TControl) as TForm; ! if FActive and (FForm <> nil) then begin + // (p3) this code is slightly dangerous: no sanity checks - + // values can become really large or really small if (FOldWidth <> 0) and (FOldHeight <> 0) then begin |