#5 autoreconn/queue fails when submitting an empty queue

[Gunnsteinn Hall]

Bug report submitted from http://junkie.doomed.org
--------------------------------------------------------
Name: wisekki
Email address: kuusisto@pp.inet.fi

Junkie version: 0.3.2cvs

Operating system: MDK9.1 you fucking know that already :)

Bug importance level: high

Is the bug reproducible? ja det är

Bug descripton (how it occured):
--------------------------------
dl finished, junkie kept idling.. crashed.

debug output:
-------------
(junkie:7933): Gtk-CRITICAL **: file ../../gtk/gtkwidget.c: line 1626
(gtk_widget_destroy): assertion `GTK_IS_WIDGET (widget)\'
failed
connect_to_lookup_cb
bab success?
removing label: 0x80c3640
SETTING MINIMIZER to -> 1

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 16384 (LWP 7933)]
0x08086cae in queue_submit (ftp=0x8214730, glist=0x80d1788)
at queue.c:722
722 if (q->status == Q_TRANSFERED) {
(gdb) up
#1 0x0805f7e6 in autoreconnect_connected_cb (ftp=0x8214730)
at
ftp_event_callback.c:1010
1010 queue_submit(ftp, glist);
(gdb) up
#2 0x08060bf4 in ftp_reconnect_cb (fd=13, ret=0,
param=0x8214730) at ftp_net.c:635
635 callback(ftp, 0, data);
(gdb) up
#3 0x0805fcf7 in connect_to_lookup_cb (jlist=0x8251ee8,
param=0x80d7ee8) at
ftp_net.c:119
119 callback(fd, 0, data);
(gdb) up
#4 0x080633af in ftp_resolver_lookup_cb (item=0x8206e80,
notused=0x0) at
ftp_resolver.c:136
136 callback(!result ? jlist : NULL, data);
(gdb) up
#5 0x08083759 in jfork_cb (fd=11, item=0x8206e80) at jfork.c:115
115 item->callback(item, item->data);
(gdb) up
#6 0x08067cc3 in gui_io_event_handler (source=0x821e598,
condition=G_IO_HUP,
data=0x824f738) at gui_io.c:152
152 ret = pass->callback(pass->fd, pass->data);
(gdb) up
Initial frame selected; you cannot go up.
------------------------
(gdb) i threads
2 Thread 32769 (LWP 7935) 0x405d0537 in poll () from
/lib/i686/libc.so.6
* 1 Thread 16384 (LWP 7933) 0x08086cae in queue_submit
(ftp=0x8214730,
glist=0x80d1788) at queue.c:722
------------------------
(gdb) bt
#0 0x08086cae in queue_submit (ftp=0x8214730,
glist=0x80d1788) at queue.c:722
#1 0x0805f7e6 in autoreconnect_connected_cb (ftp=0x8214730)
at
ftp_event_callback.c:1010
#2 0x08060bf4 in ftp_reconnect_cb (fd=13, ret=0,
param=0x8214730) at ftp_net.c:635
#3 0x0805fcf7 in connect_to_lookup_cb (jlist=0x8251ee8,
param=0x80d7ee8) at
ftp_net.c:119
#4 0x080633af in ftp_resolver_lookup_cb (item=0x8206e80,
notused=0x0) at
ftp_resolver.c:136
#5 0x08083759 in jfork_cb (fd=11, item=0x8206e80) at jfork.c:115
#6 0x08067cc3 in gui_io_event_handler (source=0x821e598,
condition=G_IO_HUP,
data=0x824f738) at gui_io.c:152

conclusion/last words:
----------------------
yeah i managed to grow some lame coder braincells and i have
already removed the bug...

[Gunnsteinn Hall]

Logged In: YES
user_id=138265

The problem seems to be that the user wasgot disconnected from the
site and had been downloading with the queue from the site.
Then junkie autoreconnecte,d, got the old queue from the
earlier session, then tried to submit the queue, which was
empty since the user had finished downloading. Then it probably
failed in queue.c
in queue_submit()
q = glist->data;

Now, if the queue was empty, then glist->data should be NULL.
if (q->status == Q_TRANSFERED)
Boom. crash.