Re: [JPP-Devel] undo/redo changes.. Re: Issues after adding loads of features as WKT

[<edg...@we...>]

On 21.01.2013 20:25, Michaël Michaud wrote:
> Hi,
>> OK, just evaluated your changes..
> Thanks,
>> A) seems to me your jumping through hoops there. wouldn't a simple "layer null check" with warning to the log in the unexecute() method have sufficed?
> Can you elaborate ? I don't think the layer is null if I don't nullify 
> it when it is removed from the LayerManager.

i take it back.. unexecute() is implemented by every tool itself, so you actually do not know which layers the EditTransaction is going to fiddle with

>> B) you create a new constructor with added layer parameter. this is used only by the tools you modded accordingly, others will probably still NPE, even with your changes? no?
> Yes, there are no so many places, but I'll need to check all 
> UndoableCommand creations.

yes, but what about plugins that are not in the OJ svn.. i am not saying wrong approach, but maybe we could find something even more elegant, more backwards compatible..

>> C) i agree with the dispose refinements though
> Only useful to deactivate edits without truncating the queue, which is 
> something you don't seem to agree with ?

not if it's not obvious to the user.. but at some point we will have to dispose the edits, hence it makes sense that you took the time there.

anyway, .. your solution is there, let's see how it works out for now.. ede