Menu

#504 TODO: OJ2.x

OJ_2.x
closed
nobody
None
not specified
5
2021-08-08
2020-09-14
ede
No

this is not actually a bug ticket, but a notepad for backward compatible breaking things to do in OJ2.x

(DONE) FeatureInstaller, privatize Constructor, replace new FeatureInstaller() with FeatureInstaller.getInstance() projectwide
(future ticket added) make the toolbar part of default-plugins.xml, to easily add/remove/reorder it's components

(DONE) rework I18N, see extra ticket https://sourceforge.net/p/jump-pilot/bugs/501/

Discussion

  • Giuseppe Aruta

    Giuseppe Aruta - 2020-10-18

    Hi Ede,
    OJ can inizialize a plugin via default-plugins.xml. Do you recommend to use it?
    Peppe

     
  • ede

    ede - 2020-10-18

    sure. at least for CORE plugins that is. it saves adding addMainMenuPlugin() and friends to the initialize() method and makes clear that default-plugins.xml is authorative, meaning it can even completely disable a plugin installation.

    not saying to change our old plugins, but use it when adding new ones, as you are doing already!

    for Extensions it makes no sense, as they exist outside of CORE, so we may add a override there (eg. i did it for the Printing plugins) but they must install fine without as well, as CORE not necessarily knows about every plugin out there.

    ..ede

     
  • ede

    ede - 2020-10-18
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -3,5 +3,6 @@
     FeatureInstaller
     privatize Constructor
     replace  new FeatureInstaller() with FeatureInstaller.getInstance() projectwide
    +(future) make the toolbar  part of default-plugins.xml, to easily add/remove/reorder it's components
    
     rework I18N, see extra ticket https://sourceforge.net/p/jump-pilot/bugs/501/
    
     
  • ede

    ede - 2021-08-08
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,8 +1,6 @@
     this is not actually a bug ticket, but a notepad for backward compatible breaking things to do in OJ2.x
    
    -FeatureInstaller
    -privatize Constructor
    -replace  new FeatureInstaller() with FeatureInstaller.getInstance() projectwide
    -(future) make the toolbar  part of default-plugins.xml, to easily add/remove/reorder it's components
    +(DONE) FeatureInstaller, privatize Constructor, replace  new FeatureInstaller() with FeatureInstaller.getInstance() projectwide
    +(future ticket added) make the toolbar  part of default-plugins.xml, to easily add/remove/reorder it's components
    
    -rework I18N, see extra ticket https://sourceforge.net/p/jump-pilot/bugs/501/
    +(DONE) rework I18N, see extra ticket https://sourceforge.net/p/jump-pilot/bugs/501/
    
    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB