Re: [JSch-users] codequality of jsch
Status: Alpha
Brought to you by:
ymnk
From: David R. <js...@di...> - 2005-03-05 12:28:36
|
Eric, This sounds like good stuff. If your changes break the API, perhaps you and Atsuhiko would consider=20= a major version number change. If this branch was released as Jsch 2.0=20= then those with the ability to upgrade, or those using Jsch for the=20 first time, can use the latest version. Those who are using jsch in=20 maintenance of an application can stick with the version 1 branch, and=20= just receive bug fixes. This approach would require more work, in terms of porting bug fixes,=20 but it sounds like this is happening already. The advantages are that new users who just google for "java ssh" find=20 the latest greatest jsch with all the improvements. And don't have to=20= dig through the mailing list archives to find out about it. So the=20 advantage is one of visibilty, which will, in an open source project,=20 lead to more support and testing. Just a suggestion like... David On 04 Mar 2005, at 17:10, Eric Meek wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jens, > > I have had the same problems as you are complaining about and have=20 > worked on fixes for jsch. All of the changes have been applied to a=20= > parallel branch and have been tested with > 60 sessions, 10 sessions=20= > simultaneously using the same JSch object with each session containing=20= > multiple active channels. Session closing, channel closing,=20 > everything appears to work fine. > > I have profiled the max threads, creation and destruction of our jsch=20= > branch under this type of usage. Before the changes there would be=20 > greater then 90 threads created without being destroyed. Now max of=20= > 20 threads created and every thread created is destroyed. > > There are two reasons I am working in a parallel branch to jsch. =20 > First is the code formatting and second I insist that the set password=20= > and passphrase methods accept and return a char[] plus other changes. =20= > In our code we don't store passwords as strings for security reasons=20= > and do not want to convert the to strings just to use jsch. Because=20= > of this, we have to change get methods in UserInfo accordingly. ymnk=20= > right now doesn't want to make that change so we are developing a=20 > parallel branch which is synced with each new version of jsch. > > If you want to try this branch, let me know. Of course, you could=20 > just wait and see what ymnk does with the changes. > > I really appreciate the incredible amount hard work ymnk has done in=20= > deciphering the ssh protocol, making a usable java library and being=20= > willing to license it under BSD. > > If anything, ymnk deserves kudos and not complaints for what he has=20 > done. > > Eric > > When you have done all things, then rely on the good providence of the=20= > almighty God for success, in full confidence that without His blessing=20= > all our efforts will inevitably fail. -- John Jay (one of the U.S.=20 > Founding Fathers and the Second President of the United States) > > On Mar 4, 2005, at 10:47 AM, Jens Zastrow wrote: > >> ok, you are right... >> >> I =B4m trying to get to work the jsch thing for one week. For simple=20= >> thing it works, but if you have multiple, parallel connections,=20 >> chanels etc. it doenst. >> >> .=85the session gets closed, sometimes, jsch hangs an on stream=85 >> >> maybe I should you a commercial api. >> >> =A0 >> >> sorry >> >> =A0 >> >> =A0 >> >> -----Original Message----- >> From: Kevin Kane [mailto:ka...@um...] >> Sent: Friday, March 04, 2005 4:03 PM >> To: Jens Zastrow >> Cc: jsc...@li... >> Subject: Re: [JSch-users] codequality of jsch >> >> =A0 >> >> At 09:44 AM 3/4/05, Jens Zastrow wrote: >> >> >> >> why the quality of the source code is so bad?! >> =A0 >> no comments in the code. >> no api-documentation ! >> =A0 >> exceptions handling like: >> =A0 >> try {=85 >> catch(Exception ee){} >> =A0 >> i wonder that such a =93heavy-used=94 api can be in a state like = this. >> >> >> No one disputes that there is room for improvement, but this is=20 >> largely a labor of love of one individual who has generously made his=20= >> code open source. With time, and with the help of the community, it=20= >> will become more polished. I suspect it would be much more=20 >> constructive if you were to write Atsuhiko and ask him how you can=20 >> help with this effort. >> -Kevin > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.4 (Darwin) > > iD8DBQFCKJZ4QFh7DSZEZ6oRAhmVAKCsAkzVoqMx2xiIkJShxjm/fpmROgCgrkGl > hdT7z8ZNYdEGk0a/Ks6ZvUk=3D > =3D1dPX > -----END PGP SIGNATURE----- > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real=20 > users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_ide95&alloc_id=14396&op=3Dclick > _______________________________________________ > JSch-users mailing list > JSc...@li... > https://lists.sourceforge.net/lists/listinfo/jsch-users |