Re: [JSch-users] JSch-0.1.37: NPE in Session.disconnect() when calledbefore authenticated
Status: Alpha
Brought to you by:
ymnk
From: <ym...@jc...> - 2008-07-17 01:06:19
|
Hi, +-From: "Oberhuber, Martin" <Mar...@wi...> -- |_Date: Wed, 16 Jul 2008 16:05:38 +0200 _______________________ | |As a rule of thumb, I've been told that it is usually |better to synchronize on local private Objects, which |the clients can not access. So, instead of synchronizing |on Session.class, I think you should synchronize on |any local Object of your choice. You are right. At first, I had thought to allocate an object for that synchronization, but I had hesitated to waist the resource and decided to re-use the existing one; Session.class OK, I agree with you. We should not use such a public object for the synchronization. I'll use private and local object. Thank for your suggestions. Sincerely, -- Atsuhiko Yamanaka JCraft,Inc. 1-14-20 HONCHO AOBA-KU, SENDAI, MIYAGI 980-0014 Japan. Tel +81-22-723-2150 +1-415-578-3454 Fax +81-22-224-8773 Skype callto://jcraft/ |