[Jrisk-cvs] SF.net SVN: domination-code:[2577] Domination

[<yu...@us...>]

Revision: 2577
          http://sourceforge.net/p/domination/code/2577
Author:   yuranet
Date:     2024-10-15 21:51:49 +0000 (Tue, 15 Oct 2024)
Log Message:
-----------
comments update and added preserveLegacyExternalStorage

Modified Paths:
--------------
    Domination/android/AndroidManifest.xml
    Domination/android/src/net/yura/domination/android/AboutActivity.java
    Domination/sharedUI/src_mini_game_ui/net/yura/domination/mobile/MiniUtil.java

Modified: Domination/android/AndroidManifest.xml
===================================================================
--- Domination/android/AndroidManifest.xml	2024-10-15 17:56:32 UTC (rev 2576)
+++ Domination/android/AndroidManifest.xml	2024-10-15 21:51:49 UTC (rev 2577)
@@ -22,7 +22,9 @@
     <!--  this is for AdMob -->
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
 
-    <!-- to be able to read maps from sd card -->
+    <!-- to be able to read maps from sd card.
+    	 Note: Starting in API level 33, this permission has no effect.
+    	 more info: https://developer.android.com/reference/android/Manifest.permission#READ_EXTERNAL_STORAGE -->
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <!-- <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> -->
 
@@ -49,6 +51,7 @@
 		         android:backupAgent="net.yura.domination.android.TheBackupAgent"
 		         android:usesCleartextTraffic="true"
 		         android:requestLegacyExternalStorage="true"
+		         android:preserveLegacyExternalStorage="true"
         >
 
 	<meta-data android:name="com.google.android.gms.games.APP_ID" android:value="@string/app_id" />

Modified: Domination/android/src/net/yura/domination/android/AboutActivity.java
===================================================================
--- Domination/android/src/net/yura/domination/android/AboutActivity.java	2024-10-15 17:56:32 UTC (rev 2576)
+++ Domination/android/src/net/yura/domination/android/AboutActivity.java	2024-10-15 21:51:49 UTC (rev 2577)
@@ -59,6 +59,8 @@
                         // technically we can start using this API if >= lolli
                         // but its so broken and buggy in those versions so we only use it when we have to
                         // https://developer.android.com/training/data-storage/use-cases#opt-out-in-production-app
+                        // we HAVE to start using the new method in 30, as fresh installs have no option to use old method
+                        // Android 11 (API level 30) https://developer.android.com/about/versions/11/privacy/storage
                         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { // API-30
                             openDirectory(url);
                             return true;

Modified: Domination/sharedUI/src_mini_game_ui/net/yura/domination/mobile/MiniUtil.java
===================================================================
--- Domination/sharedUI/src_mini_game_ui/net/yura/domination/mobile/MiniUtil.java	2024-10-15 17:56:32 UTC (rev 2576)
+++ Domination/sharedUI/src_mini_game_ui/net/yura/domination/mobile/MiniUtil.java	2024-10-15 21:51:49 UTC (rev 2577)
@@ -236,7 +236,7 @@
      * This is really only used for android, as on desktop and iOS you can access the main maps folder
      */
     private static String externalMapsDirUrl;
-    static String getExternalMapDir() {
+    public static String getExternalMapDir() {
         if (externalMapsDirUrl != null) {
             return externalMapsDirUrl;
         }