I ran into a copybook which uses 9(5).99-, and apparently that doesn't get recognized as a numeric field. I'm having a go at fixing this, and if I succeed I'll pass on the changes.
Indeed that was where I had got to. It's not as easy as I had hoped (I fixed checkPictureNumeric to accept that type of picture, but they came back as right-justified decimals (type 6) instead of type 10), so I don't think the conversion would have happened correctly... but I think it's doable.
While I'm working on that (on my own time) I'm adding a special case to my own code that checks for fields with trailing "-" and if they're otherwise parseable as Java numbers... do so.
Status: open
Group: Next_Release_(example)
Created: Wed Feb 25, 2015 07:06 PM UTC by Nick Briggs
Last Updated: Wed Feb 25, 2015 07:06 PM UTC
Owner: Bruce Martin
I ran into a copybook which uses 9(5).99-, and apparently that doesn't get recognized as a numeric field. I'm having a go at fixing this, and if I succeed I'll pass on the changes.
Status: open
Group: Next_Release_(example)
Created: Wed Feb 25, 2015 07:06 PM UTC by Nick Briggs
Last Updated: Wed Feb 25, 2015 11:11 PM UTC
Owner: Bruce Martin
I ran into a copybook which uses 9(5).99-, and apparently that doesn't get recognized as a numeric field. I'm having a go at fixing this, and if I succeed I'll pass on the changes.
Indeed that was where I had got to. It's not as easy as I had hoped (I fixed checkPictureNumeric to accept that type of picture, but they came back as right-justified decimals (type 6) instead of type 10), so I don't think the conversion would have happened correctly... but I think it's doable.
While I'm working on that (on my own time) I'm adding a special case to my own code that checks for fields with trailing "-" and if they're otherwise parseable as Java numbers... do so.
-- Nick
Related
Feature Requests: #5
Will let you have a look at it,
If you want a hint, have a look in:
There will need to be changes in getTypeIdentifier in basic conversion
and finally there is a bug in the class TypeSignSeparate that needs to fixed. It only affects the updating of fields; I will do this.
Correction TypeSignSeparate is correct
Last edit: Bruce Martin 2015-02-26
Here's the damage I've done so far to get some things working -- patches are against the read-only checkout of the code:
I couldn't run all your JUnit tests, but I don't think I've done too badly. Feel free to change style/hack in any way you think is appropriate.
-- Nick
Related
Feature Requests: #5