Menu

#12 ThreadContextAwareResolver bug in isrt

v1.0 (example)
closed-fixed
mtraut
None
2
2014-01-07
2013-12-19
Tomas Bucki
No

this method:
synchronized public static void remove(IStringEvaluator pResolver) {
ScopedResolver tempResolver = resolver.get(); // NPE error can occur !!!
if (resolver == null) {
return;
}
tempResolver.removeResolver(pResolver);
}
should be:
synchronized public static void remove(IStringEvaluator pResolver) {
if (resolver != null) {
resolver.get().removeResolver(pResolver);
}
}

Discussion

  • mtraut

    mtraut - 2014-01-07

    you're right there's a bug here, too. Again we had to change the proposed fix to

    synchronized public static void remove(IStringEvaluator pResolver) {
        ScopedResolver tempResolver = resolver.get();
        if (tempResolver == null) {
            return;
        }
        tempResolver.removeResolver(pResolver);
    }
    
     
  • mtraut

    mtraut - 2014-01-07
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB