From: Josip R. <jo...@sr...> - 2003-05-30 09:53:41
|
Hi, I just tried the latest joe from CVS and the word delimiters are still different from the old joe. That is, characters like /, ', . or _ aren't considered to delineate different words, so ^X/^Z skip over them. Will this ever be changed? If not changed, will it at least be made a configurable option? -- 2. That which causes joy or happiness. |
From: Mikhael G. <mi...@ho...> - 2003-05-30 14:07:22
|
On 30 May 2003 11:53:26 +0200, Josip Rodin wrote: > > I just tried the latest joe from CVS and the word delimiters are still > different from the old joe. That is, characters like /, ', . or _ aren't > considered to delineate different words, so ^X/^Z skip over them. > > Will this ever be changed? If not changed, will it at least be made a > configurable option? I am a bit disappointed too, I thought Marek agreed in one of the messages that the default should be restored. BTW, waiting for 3.0. :) Regards, Mikhael. |
From: Vitezslav S. <sa...@ma...> - 2003-05-30 19:11:05
|
On Fri, May 30, 2003 at 11:53:26AM +0200, Josip Rodin wrote: > Hi, > > I just tried the latest joe from CVS and the word delimiters are still > different from the old joe. That is, characters like /, ', . or _ aren't > considered to delineate different words, so ^X/^Z skip over them. Will try to look at it over weekend. Stay tuned. > Will this ever be changed? If not changed, will it at least be made a > configurable option? Marek promised configurable option, sent me a patch which uses PCRE, but I will not even try to push his patch into stable releases - this can wait for 3.x. I think dependency on this library is not necessary now. Cheers, Vita |
From: Marek G. <xg...@in...> - 2003-05-30 20:22:00
|
Hi, On Fri, 30 May 2003, Vitezslav Samel wrote: > On Fri, May 30, 2003 at 11:53:26AM +0200, Josip Rodin wrote: > > Will this ever be changed? If not changed, will it at least be made a > > configurable option? >=20 > Marek promised configurable option, sent me a patch which uses PCRE, = but > I will not even try to push his patch into stable releases - this can w= ait > for 3.x. I think dependency on this library is not necessary now. I'm sorry for be such passive but I'll be graduate in month so i'm trying to concentrate on other things. But I have enough theory and need to program something :) so I will try to rewrite this patch to be usefull also without PCRE. Coming soon... pax, marx -- [****************************][*************************************] [ marek 'marx' gr=E1c / gerard ][ Sikhav gad=BEeske, hoj sal manu=B9, = ] [ ][ jov nike sikhavela, ] [ xg...@fi... ][ hoj the jov hin manu=B9 ] [****************************][*************************************] |
From: Vitezslav S. <sa...@ma...> - 2003-06-02 09:55:10
|
On Fri, May 30, 2003 at 08:56:08PM +0200, Vitezslav Samel wrote: > On Fri, May 30, 2003 at 11:53:26AM +0200, Josip Rodin wrote: > > Hi, > > > > I just tried the latest joe from CVS and the word delimiters are still > > different from the old joe. That is, characters like /, ', . or _ aren't > > considered to delineate different words, so ^X/^Z skip over them. > > Will try to look at it over weekend. Stay tuned. Can you try the latest CVS? Now ^X/^Z should work the same as ^W/^O. Cheers, Vita |
From: Josip R. <jo...@sr...> - 2003-06-02 10:17:36
|
On Mon, Jun 02, 2003 at 11:54:41AM +0200, Vitezslav Samel wrote: > > > I just tried the latest joe from CVS and the word delimiters are still > > > different from the old joe. That is, characters like /, ', . or _ aren't > > > considered to delineate different words, so ^X/^Z skip over them. > > > > Will try to look at it over weekend. Stay tuned. > > Can you try the latest CVS? Now ^X/^Z should work the same as ^W/^O. That's better, but now it goes too far :) It doesn't skip over the spaces. -- 2. That which causes joy or happiness. |
From: Vitezslav S. <sa...@ma...> - 2003-06-02 14:11:22
|
On Mon, Jun 02, 2003 at 12:13:12PM +0200, Josip Rodin wrote: > On Mon, Jun 02, 2003 at 11:54:41AM +0200, Vitezslav Samel wrote: > > > > I just tried the latest joe from CVS and the word delimiters are still > > > > different from the old joe. That is, characters like /, ', . or _ aren't > > > > considered to delineate different words, so ^X/^Z skip over them. > > > > > > Will try to look at it over weekend. Stay tuned. > > > > Can you try the latest CVS? Now ^X/^Z should work the same as ^W/^O. > > That's better, but now it goes too far :) It doesn't skip over the spaces. Take two: please, try the following patch (I'm comparing this to version 2.8: it has slightly different behaviour, but it's not certainly bad). Patch is against current CVS. Cheers, Vita diff -urN -X /home/samel/joe/dontdiff 04-dont_beep/uedit.c 05-prev_word2/uedit.c --- 04-dont_beep/uedit.c Mon Jun 2 09:45:34 2003 +++ 05-prev_word2/uedit.c Mon Jun 2 13:05:08 2003 @@ -105,8 +105,10 @@ prgetc(p); if (c != NO_MORE_DATA) pgetc(p); - } else if (isspace(c)) { - while (isspace(c = brc(p))) + } else if (isspace(c) || ispunct(c)) { + while (isspace(c = brc(p)) || ispunct(c)) + prgetc(p); + while (isalnum_(c = brc(p))) prgetc(p); if (c != NO_MORE_DATA) pgetc(p); @@ -134,10 +136,12 @@ if (isalnum_(c)) while (isalnum_(c = brc(p))) pgetc(p); - else if (isspace(c)) - while (isspace(c = brc(p))) + else if (isspace(c) || ispunct(c)) { + while (isspace(c = brc(p)) || ispunct(c)) + pgetc(p); + while (isalnum_(c = brc(p))) pgetc(p); - else + } else pgetc(p); if (p->byte == bw->cursor->byte) { prm(p); |
From: Vitezslav S. <sa...@ma...> - 2003-06-16 10:59:20
|
On Mon, Jun 02, 2003 at 03:09:55PM +0200, Vitezslav Samel wrote: > On Mon, Jun 02, 2003 at 12:13:12PM +0200, Josip Rodin wrote: > > On Mon, Jun 02, 2003 at 11:54:41AM +0200, Vitezslav Samel wrote: > > > > > I just tried the latest joe from CVS and the word delimiters are still > > > > > different from the old joe. That is, characters like /, ', . or _ aren't > > > > > considered to delineate different words, so ^X/^Z skip over them. > > > > > > > > Will try to look at it over weekend. Stay tuned. > > > > > > Can you try the latest CVS? Now ^X/^Z should work the same as ^W/^O. > > > > That's better, but now it goes too far :) It doesn't skip over the spaces. > > Take two: please, try the following patch (I'm comparing this to version 2.8: > it has slightly different behaviour, but it's not certainly bad). > Patch is against current CVS. Are there any problems with the following patch or should I commit this to CVS? Cheers, Vita > diff -urN -X /home/samel/joe/dontdiff 04-dont_beep/uedit.c 05-prev_word2/uedit.c > --- 04-dont_beep/uedit.c Mon Jun 2 09:45:34 2003 > +++ 05-prev_word2/uedit.c Mon Jun 2 13:05:08 2003 > @@ -105,8 +105,10 @@ > prgetc(p); > if (c != NO_MORE_DATA) > pgetc(p); > - } else if (isspace(c)) { > - while (isspace(c = brc(p))) > + } else if (isspace(c) || ispunct(c)) { > + while (isspace(c = brc(p)) || ispunct(c)) > + prgetc(p); > + while (isalnum_(c = brc(p))) > prgetc(p); > if (c != NO_MORE_DATA) > pgetc(p); > @@ -134,10 +136,12 @@ > if (isalnum_(c)) > while (isalnum_(c = brc(p))) > pgetc(p); > - else if (isspace(c)) > - while (isspace(c = brc(p))) > + else if (isspace(c) || ispunct(c)) { > + while (isspace(c = brc(p)) || ispunct(c)) > + pgetc(p); > + while (isalnum_(c = brc(p))) > pgetc(p); > - else > + } else > pgetc(p); > if (p->byte == bw->cursor->byte) { > prm(p); |
From: Josip R. <jo...@sr...> - 2003-06-16 13:28:38
|
On Mon, Jun 16, 2003 at 12:58:51PM +0200, Vitezslav Samel wrote: > > > > > > I just tried the latest joe from CVS and the word delimiters are still > > > > > > different from the old joe. That is, characters like /, ', . or _ aren't > > > > > > considered to delineate different words, so ^X/^Z skip over them. > > > > > > > > > > Will try to look at it over weekend. Stay tuned. > > > > > > > > Can you try the latest CVS? Now ^X/^Z should work the same as ^W/^O. > > > > > > That's better, but now it goes too far :) It doesn't skip over the spaces. > > > > Take two: please, try the following patch (I'm comparing this to version 2.8: > > it has slightly different behaviour, but it's not certainly bad). > > Patch is against current CVS. > > Are there any problems with the following patch or should I commit this > to CVS? Thanks for the reminder -- it is indeed better, please commit it at will. The only two differences I found: * the old ^X, when encountering a full stop at the end of the paragraph, stopped before and after it. The new one stops only before it, which I think is actually better! * the old ^X doesn't skip over underscores (_), new one does. Should probably undo this in the new one. -- 2. That which causes joy or happiness. |
From: Vitezslav S. <sa...@ma...> - 2003-06-16 13:59:07
|
Hi! > > > Take two: please, try the following patch (I'm comparing this to version 2.8: > > > it has slightly different behaviour, but it's not certainly bad). > > > Patch is against current CVS. > > > > Are there any problems with the following patch or should I commit this > > to CVS? > > Thanks for the reminder -- it is indeed better, please commit it at will. > > The only two differences I found: > > * the old ^X, when encountering a full stop at the end of the paragraph, > stopped before and after it. The new one stops only before it, which I > think is actually better! > > * the old ^X doesn't skip over underscores (_), new one does. > Should probably undo this in the new one. What version is "old"? Just tried 2.8 - this version skips over underscores, which is IMHO better (think of variable or function names in C etc.). Commiting this "new" version to CVS. Cheers, Vita |
From: Josip R. <jo...@sr...> - 2003-06-16 14:30:00
|
On Mon, Jun 16, 2003 at 03:58:33PM +0200, Vitezslav Samel wrote: > > * the old ^X doesn't skip over underscores (_), new one does. > > Should probably undo this in the new one. > > What version is "old"? Just tried 2.8 - this version skips over underscores I guess that's my patched 2.8 that doesn't. Oh well, for the record, I like the underscores to be word delimiters. -- 2. That which causes joy or happiness. |
From: Josip R. <jo...@sr...> - 2003-08-15 18:25:40
|
On Mon, Jun 16, 2003 at 03:58:33PM +0200, Vitezslav Samel wrote: > Commiting this "new" version to CVS. BTW, when's a new release coming out with this patch? :) -- 2. That which causes joy or happiness. |