Menu

#33 jm.midi.MidiPraser.scoreToSMF does not work with chords

open
nobody
5
2013-02-07
2007-08-07
ec0000
No

In fact, it does not work with phrases/notes with the same start time.

Within class jm.midi.MidiPraser...

In public void MidiPraser.scoreToSMF(Score score, SMF smf) {
....
// in the last while loop

startTime = phrase.getStartTime() * partTempoMultiplier;
.....

// Towards the end of the while loop, the startTime is moved forwarded regardless of what is coming next

// move the note-on time forward by the rhythmic value
startTime += tickRounder(note.getRhythmValue() * phraseTempoMultiplier); //time between start times
...

If the phrases within the part is indeed sorted by startTime according to the comment, then the output startTime should only move forward if the next phrase/note does not start at the same time. The sorting routine also seems to be problematic as well.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB