From: JMRI B. <jm...@em...> - 2018-02-15 23:02:27
|
See <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/2305/display/redirect?page=changes> Changes: [daboudreau] Some minor code cleanup ------------------------------------------ [...truncated 62.31 KB...] [javac] ---------- [javac] ---------- [javac] 54. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/display/layoutEditor/PositionablePoint.java> (at line 1610) [javac] TrackNameSet = null; // assume not found (pessimist!) [javac] ^^^^^^^^^^^^ [javac] Redundant assignment: The variable TrackNameSet can only be null at this location [javac] ---------- [javac] ---------- [javac] 55. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/display/layoutEditor/TrackSegment.java> (at line 1798) [javac] TrackNameSet = null; // assume not found (pessimist!) [javac] ^^^^^^^^^^^^ [javac] Redundant assignment: The variable TrackNameSet can only be null at this location [javac] ---------- [javac] ---------- [javac] 56. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/display/palette/MultiSensorItemPanel.java> (at line 203) [javac] int row = _model.getIndexOf(bean); [javac] ^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The method getIndexOf(NamedBean) belongs to the raw type PickListModel. References to generic type PickListModel<E> should be parameterized [javac] ---------- [javac] ---------- [javac] 57. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/display/palette/TableItemPanel.java> (at line 176) [javac] int setRow = _model.getIndexOf(bean); [javac] ^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The method getIndexOf(NamedBean) belongs to the raw type PickListModel. References to generic type PickListModel<E> should be parameterized [javac] ---------- [javac] 58. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/display/palette/TableItemPanel.java> (at line 219) [javac] int row = _model.getIndexOf(bean); [javac] ^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The method getIndexOf(NamedBean) belongs to the raw type PickListModel. References to generic type PickListModel<E> should be parameterized [javac] ---------- [javac] ---------- [javac] 59. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/entryexit/EntryExitPairs.java> (at line 927) [javac] LayoutEditor sPanel = pdSrc.getPanel(); [javac] ^^^^^^ [javac] The value of the local variable sPanel is not used [javac] ---------- [javac] ---------- [javac] 60. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/picker/PickPanel.java> (at line 103) [javac] int setRow = model.getIndexOf(bean); [javac] ^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The method getIndexOf(NamedBean) belongs to the raw type PickListModel. References to generic type PickListModel<E> should be parameterized [javac] ---------- [javac] ---------- [javac] 61. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/signalling/SignallingPanel.java> (at line 1621) [javac] protected JComboBox getEditorBox(int row) { [javac] ^^^^^^^^^ [javac] Type safety: The return type JComboBox for getEditorBox(int) from the type SignallingPanel.TableModel.StateComboBoxPanel needs unchecked conversion to conform to JComboBox<String> from the type RowComboBoxPanel [javac] ---------- [javac] 62. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/signalling/SignallingPanel.java> (at line 1759) [javac] JComboBox getStateEditorBox(int row) { [javac] ^^^^^^^^^ [javac] Type safety: The return type JComboBox for getStateEditorBox(int) from the type SignallingPanel.BlockModel needs unchecked conversion to conform to JComboBox<String> from the type SignallingPanel.TableModel [javac] ---------- [javac] 63. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/signalling/SignallingPanel.java> (at line 1848) [javac] JComboBox getStateEditorBox(int row) { [javac] ^^^^^^^^^ [javac] Type safety: The return type JComboBox for getStateEditorBox(int) from the type SignallingPanel.TurnoutModel needs unchecked conversion to conform to JComboBox<String> from the type SignallingPanel.TableModel [javac] ---------- [javac] 64. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/signalling/SignallingPanel.java> (at line 1932) [javac] JComboBox getStateEditorBox(int row) { [javac] ^^^^^^^^^ [javac] Type safety: The return type JComboBox for getStateEditorBox(int) from the type SignallingPanel.SensorModel needs unchecked conversion to conform to JComboBox<String> from the type SignallingPanel.TableModel [javac] ---------- [javac] 65. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/signalling/SignallingPanel.java> (at line 2089) [javac] protected JComboBox getEditorBox(int row) { [javac] ^^^^^^^^^ [javac] Type safety: The return type JComboBox for getEditorBox(int) from the type SignallingPanel.SignalMastModel.AspectComboBoxPanel needs unchecked conversion to conform to JComboBox<String> from the type RowComboBoxPanel [javac] ---------- [javac] ---------- [javac] 66. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/vsdecoder/swing/DieselPane.java> (at line 229) [javac] private static final Logger log = LoggerFactory.getLogger(DieselPane.class); [javac] ^^^ [javac] The value of the field DieselPane.log is not used [javac] ---------- [javac] ---------- [javac] 67. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrit/withrottle/AbstractController.java> (at line 53) [javac] sysNameList = manager.getSystemNameList(); [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The expression of type List needs unchecked conversion to conform to List<String> [javac] ---------- [javac] ---------- [javac] 68. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/easydcc/simulator/EasyDccSimulatorTrafficController.java> (at line 37) [javac] private final static Logger log = LoggerFactory.getLogger(EasyDccSimulatorTrafficController.class); [javac] ^^^ [javac] The value of the field EasyDccSimulatorTrafficController.log is not used [javac] ---------- [javac] ---------- [javac] 69. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/loconet/bdl16/BDL16Panel.java> (at line 285) [javac] comboBox = new JComboBox[48]; // can't use JComboBox<String>[48] as you can't have an array of type-erased types [javac] ^^^^^^^^^^^^^^^^^ [javac] Type safety: The expression of type JComboBox[] needs unchecked conversion to conform to JComboBox<String>[] [javac] ---------- [javac] ---------- [javac] 70. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/loconet/sdf/SdfMacro.java> (at line 221) [javac] private final static Logger log = LoggerFactory.getLogger(SdfMacro.class); [javac] ^^^ [javac] The value of the field SdfMacro.log is not used [javac] ---------- [javac] ---------- [javac] 71. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/roco/z21/Z21XNetTurnout.java> (at line 88) [javac] synchronized void initmessage(XNetReply l) { [javac] ^^^^^^^^^^^^^^^^^^^^^^^^ [javac] The method Z21XNetTurnout.initmessage(XNetReply) does not override the inherited method from XNetTurnout since it is private to a different package [javac] ---------- [javac] ---------- [javac] 72. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/sprog/SprogCommandStation.java> (at line 397) [javac] private int statusDue = 0; [javac] ^^^^^^^^^ [javac] The value of the field SprogCommandStation.statusDue is not used [javac] ---------- [javac] ---------- [javac] 73. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/sprog/simulator/SimulatorAdapter.java> (at line 40) [javac] private boolean trackPowerState = false; [javac] ^^^^^^^^^^^^^^^ [javac] The value of the field SimulatorAdapter.trackPowerState is not used [javac] ---------- [javac] ---------- [javac] 74. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/jmrix/tams/swing/TamsNamedPaneAction.java> (at line 45) [javac] private final static Logger log = LoggerFactory.getLogger(TamsNamedPaneAction.class); [javac] ^^^ [javac] The value of the field TamsNamedPaneAction.log is not used [javac] ---------- [javac] ---------- [javac] 75. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/util/swing/JComboBoxUtil.java> (at line 29) [javac] Component c = renderer.getListCellRendererComponent(list, value, i, false, false); [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The method getListCellRendererComponent(JList, Object, int, boolean, boolean) belongs to the raw type ListCellRenderer. References to generic type ListCellRenderer<E> should be parameterized [javac] ---------- [javac] ---------- [javac] 76. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/util/swing/JmriBeanComboBox.java> (at line 514) [javac] List<NamedBean> namedBeanList = uDaManager.getNamedBeanList(); [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The expression of type List needs unchecked conversion to conform to List<NamedBean> [javac] ---------- [javac] 77. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/util/swing/JmriBeanComboBox.java> (at line 742) [javac] setRenderer(_enableRenderer); [javac] ^^^^^^^^^^^^^^^ [javac] Type safety: The expression of type JmriBeanComboBox.EnabledComboBoxRenderer needs unchecked conversion to conform to ListCellRenderer<? super String> [javac] ---------- [javac] ---------- [javac] 78. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/util/usb/UsbBrowserPanel.java> (at line 144) [javac] List<UsbDevice> usbDevices = usbHub.getAttachedUsbDevices(); [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The expression of type List needs unchecked conversion to conform to List<UsbDevice> [javac] ---------- [javac] ---------- [javac] 79. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/util/usb/UsbUtil.java> (at line 188) [javac] List<UsbDevice> usbDevices = usbHub.getAttachedUsbDevices(); [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [javac] Type safety: The expression of type List needs unchecked conversion to conform to List<UsbDevice> [javac] ---------- [javac] ---------- [javac] 80. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/web/servlet/json/JsonServlet.java> (at line 77) [javac] JsonHttpService service = factory.getHttpService(this.mapper); [javac] ^^^^^^^ [javac] The value of the local variable service is not used [javac] ---------- [javac] ---------- [javac] 81. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/src/jmri/web/servlet/panel/PanelServlet.java> (at line 139) [javac] for (Positionable sub : editor.getContents()) { [javac] ^^^ [javac] The value of the local variable sub is not used [javac] ---------- [javac] 81 problems (81 warnings) tests-warnings: [mkdir] Created dir: <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/target/test-classes> [javac] Compiling 4396 source files to <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/target/test-classes> [javac] ---------- [javac] 1. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/jmrix/ieee802154/xbee/XBeeConnectionMemoTest.java> (at line 30) [javac] private static boolean rv = true; [javac] ^^ [javac] The value of the field XBeeConnectionMemoTest.rv is not used [javac] ---------- [javac] ---------- [javac] 2. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/jmrix/openlcb/OlcbConfigurationManagerScaffold.java> (at line 105) [javac] private final static Logger log = LoggerFactory.getLogger(OlcbConfigurationManagerScaffold.class); [javac] ^^^ [javac] The value of the field OlcbConfigurationManagerScaffold.log is not used [javac] ---------- [javac] ---------- [javac] 3. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/jmrix/openlcb/OlcbSensorTest.java> (at line 29) [javac] private static final String KNOWN_STATE = "KnownState"; [javac] ^^^^^^^^^^^ [javac] The value of the field OlcbSensorTest.KNOWN_STATE is not used [javac] ---------- [javac] ---------- [javac] 4. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/jmrix/openlcb/OlcbTurnoutTest.java> (at line 28) [javac] private static final String COMMANDED_STATE = "CommandedState"; [javac] ^^^^^^^^^^^^^^^ [javac] The value of the field OlcbTurnoutTest.COMMANDED_STATE is not used [javac] ---------- [javac] 5. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/jmrix/openlcb/OlcbTurnoutTest.java> (at line 29) [javac] private static final String KNOWN_STATE = "KnownState"; [javac] ^^^^^^^^^^^ [javac] The value of the field OlcbTurnoutTest.KNOWN_STATE is not used [javac] ---------- [javac] ---------- [javac] 6. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/jmrix/roco/z21/simulator/Z21SimulatorTest.java> (at line 21) [javac] private static java.net.InetAddress host; [javac] ^^^^ [javac] The value of the field Z21SimulatorTest.host is not used [javac] ---------- [javac] ---------- [javac] 7. WARNING in <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/test/jmri/util/junit/rules/RetryRule.java> (at line 44) [javac] throw caughtThrowable; [javac] ^^^^^^^^^^^^^^^ [javac] Potential null pointer access: The variable caughtThrowable may be null at this location [javac] ---------- [javac] 7 problems (7 warnings) init: jjtree: javacc: copyfiles: update-template-code: [copy] Copying 1 file to <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/java/tmp> compile-generated-source: [copy] Copying 1 file to <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/target/classes/jmri> debug: tests: [javac] Compiling 2 source files to <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/target/test-classes> [javac] warning: Supported source version 'RELEASE_7' from annotation processor 'org.netbeans.modules.openide.util.ServiceProviderProcessor' less than -source '1.8' [javac] warning: Supported source version 'RELEASE_7' from annotation processor 'org.netbeans.modules.openide.util.NamedServiceProcessor' less than -source '1.8' [javac] 2 warnings [copy] Copying 207 files to <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/target/test-classes> runtime-library-selection: [echo] arch.lib.path <http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/lib/linux/x86_64>:<http://jmri.tagadab.com/jenkins/job/Development/job/Builds/ws/lib/linux> headlesstest: [jacoco:coverage] Enhancing junit with coverage [junit] Running jmri.HeadLessTest [junit] fork(): Cannot allocate memory [junit] AL lib: (WW) alc_initconfig: Failed to initialize backend "pulse" [junit] AL lib: (WW) alc_initconfig: Failed to initialize backend "alsa" [junit] AL lib: (EE) ALCplaybackOSS_open: Could not open /dev/dsp: No such file or directory Build step 'Invoke Ant' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? Not sending mail to unregistered user dab...@ho... |