Re: [Jmol-developers] commit or patch?

[Jonathan G. <gu...@uw...>]

Angel,
	Unless others can think of a reason, I'd suggest commit and we will  
test.  However, note that Bob just did some changes to when the dialog  
is activated.  Make sure to merge those changes in before you commit.
	Since we can monitor commits, we will have some idea of what to check.

	I also like your idea for rearranging the menu.

Jonathan
On Sep 3, 2009, at 2:17 PM, Angel Herráez wrote:

> Dear developers,
>
> I've been playing a bit with getting all the exporters open a File  
> Save dialog when called
> from the app's popup menu. My changes for now affect only one java  
> file, but there are
> some other things I'd like to adapt (like isosurface export) and I'm  
> not sure if that will affect
> other files.
>
> I have modified ScriptEvaluator.java locally and built the app,  
> which works as far as the
> dialogs are concerned. I am however worried about having broken  
> something else.
>
> So my question is: what is best, should I just commit the change, or  
> better set up a Patch or
> Branch  (which I don't know yet how to do)?
>
>
> On the other hand, I would like to reorganize the popup menu so that  
> load and save/export
> options are collected into a File menu, and I'd rather put it near  
> the bottom so that the view
> style options are the first (after all, Jmol's main use is as a  
> viewer).
>
> I'd welcome opinions on this setup
> I will poll the user list also about this.
>
> Thanks
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008  
> 30-Day
> trial. Simplify your report design, integration and deployment - and  
> focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Jmol-developers mailing list
> Jmo...@li...
> https://lists.sourceforge.net/lists/listinfo/jmol-developers

                          Dr. Jonathan H. Gutow
Chemistry Department                                 gu...@uw...
UW-Oshkosh                                           Office:920-424-1326
800 Algoma Boulevard                                 FAX:920-424-2042
Oshkosh, WI 54901
                  http://www.uwosh.edu/faculty_staff/gutow/