Menu
▾
▴
Re: [Jmol-developers] Eclipse plugin: Findbugs
|
From: Nicolas V. <nve...@gm...> - 2008-10-26 09:30:56
|
On Sun, Oct 26, 2008 at 8:14 AM, Egon Willighagen < ego...@gm...> wrote: > On Sat, Oct 25, 2008 at 8:43 PM, Nicolas Vervelle <nve...@gm...> > wrote: > > I have started configuring the Findbugs plugin for Eclipse. > > If you are interested in seeing the result, install the plugin [1] and > get > > the latest version > > How does it compare to PMD? > > http://pmd.sourceforge.net/reports/jmol_Jmol.html > It's quite different and the warnings reported are different also. I think PMD is working on the .java files while Findbugs is working on the .class files Currently, it reports 150 warnings in several areas : - Null pointer derefencing - Floating point comparisons - Unwritten or unused fields - Streams not always closed - Unnecessary tests - Unnecessary affectations - Ignoring some methods results - Serialization problems - Redundant code - Integer / Long conversions Nico Current report : Description Resource Path Location Type H D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.viewer.Eval.runEval(boolean, boolean, boolean, boolean) Eval.java Jmol/src/org/jmol/viewer line 307 FindBugs Problem (High Priority) H D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.viewer.FileManager.getInputStream(String, boolean, URL, String) FileManager.java Jmol/src/org/jmol/viewer line 670 FindBugs Problem (High Priority) H D FE: Test d'égalité avec NaN erroné dans org.jmol.viewer.Eval.ellipsoid() Eval.java Jmol/src/org/jmol/viewer line 5938 FindBugs Problem (High Priority) H D FE: Test d'égalité en virgule flottante dans org.jmol.g3d.Graphics3D.getFont3DScaled(Font3D, float). Graphics3D.java Jmol/src/org/jmol/g3d line 2256 FindBugs Problem (High Priority) H D FE: Test d'égalité en virgule flottante dans org.jmol.jvxl.calc.MarchingSquares.getContourType(Point4f, Vector3f[]). MarchingSquares.java Jmol/src/org/jmol/jvxl/calc line 137 FindBugs Problem (High Priority) H D FE: Test d'égalité en virgule flottante dans org.jmol.jvxl.readers.Parameters.setMapRanges(VoxelReader). Parameters.java Jmol/src/org/jmol/jvxl/readers line 672 FindBugs Problem (High Priority) H D FE: Test d'égalité en virgule flottante dans org.jmol.shape.Dots.setSize(int, BitSet). Dots.java Jmol/src/org/jmol/shape line 211 FindBugs Problem (High Priority) H D FE: Test d'égalité en virgule flottante dans org.jmol.viewer.TransformManager.addZoomTranslationNavigationText(StringBuffer). TransformManager.java Jmol/src/org/jmol/viewer line 1686 FindBugs Problem (High Priority) H D FE: Test d'égalité en virgule flottante dans org.jmol.viewer.TransformManager11.calcCameraFactors(). TransformManager11.java Jmol/src/org/jmol/viewer line 111 FindBugs Problem (High Priority) H D NP: Possible déréférencement d'un pointeur null dans org.jmol.minimize.forcefield.ForceFieldUFF.getAtomTypes() ForceFieldUFF.java Jmol/src/org/jmol/minimize/forcefield line 145 FindBugs Problem (High Priority) H D NP: Possible déréférencement d'un pointeur null dans org.jmol.minimize.forcefield.ForceFieldUFF.getFFParameters() ForceFieldUFF.java Jmol/src/org/jmol/minimize/forcefield line 65 FindBugs Problem (High Priority) H D NP: Possible déréférencement d'un pointeur null dans org.jmol.shapesurface.Isosurface.notifySurfaceGenerationCompleted() Isosurface.java Jmol/src/org/jmol/shapesurface line 680 FindBugs Problem (High Priority) H D RCN: Test de nullité dans org.jmol.symmetry.SpaceGroup.hallInfo d'une valeur préalablement déréférencée dans org.jmol.symmetry.SpaceGroup.dumpInfo() SpaceGroup.java Jmol/src/org/jmol/symmetry line 234 FindBugs Problem (High Priority) H D RpC: Repeated conditional test in org.jmol.shapespecial.DrawRenderer.render2() DrawRenderer.java Jmol/src/org/jmol/shapespecial line 93 FindBugs Problem (High Priority) H D ST: Ecriture d'un champ statique org.jmol.g3d.Sphere3D.nIn depuis la méthode d'une instance org.jmol.g3d.Sphere3D.render(int[], boolean, int, int, int, int, Matrix3f, double[], Matrix4f, int, Point3i[]) Sphere3D.java Jmol/src/org/jmol/g3d line 180 FindBugs Problem (High Priority) H D ST: Ecriture d'un champ statique org.jmol.g3d.Sphere3D.nOut depuis la méthode d'une instance org.jmol.g3d.Sphere3D.render(int[], boolean, int, int, int, int, Matrix3f, double[], Matrix4f, int, Point3i[]) Sphere3D.java Jmol/src/org/jmol/g3d line 180 FindBugs Problem (High Priority) H D ST: Ecriture d'un champ statique org.jmol.g3d.Swing3D.backgroundTransparent depuis la méthode d'une instance org.jmol.g3d.Swing3D.setBackgroundTransparent(boolean) Swing3D.java Jmol/src/org/jmol/g3d line 103 FindBugs Problem (High Priority) H D UCF: Useless control flow to next line in org.jmol.viewer.StateManager.getCommands(Hashtable, StringBuffer, String, int, String) StateManager.java Jmol/src/org/jmol/viewer line 1309 FindBugs Problem (High Priority) H V MS: org.jmol.viewer.Viewer.testData n'est pas final mais devrait l'être Viewer.java Jmol/src/org/jmol/viewer line 2621 FindBugs Problem (High Priority) H V MS: org.jmol.viewer.Viewer.testData2 n'est pas final mais devrait l'être Viewer.java Jmol/src/org/jmol/viewer line 2622 FindBugs Problem (High Priority) M B DE: org.openscience.jmol.app.AtomSetChooser.showAtomSetIndex(int, boolean) peut ignorer AtomSetChooser.java:[line 427] AtomSetChooser.java Jmol/src/org/openscience/jmol/app line 427 FindBugs Problem (Normal Priority) M B DE: org.openscience.jmol.app.GaussianDialog.save() peut ignorer GaussianDialog.java:[line 448] GaussianDialog.java Jmol/src/org/openscience/jmol/app line 448 FindBugs Problem (Normal Priority) M B DE: org.openscience.jmol.app.PreferencesDialog.initializeProperties() peut ignorer PreferencesDialog.java:[line 588] PreferencesDialog.java Jmol/src/org/openscience/jmol/app line 588 FindBugs Problem (Normal Priority) M B RR: org.jmol.util.BinaryDocument.readByteArray(byte[], int, int) ignore le résultat de java.io.DataInputStream.read(byte[], int, int) BinaryDocument.java Jmol/src/org/jmol/util line 81 FindBugs Problem (Normal Priority) M B RR: org.jmol.util.BinaryDocument.readByteArray(byte[]) ignore le résultat de java.io.DataInputStream.read(byte[]) BinaryDocument.java Jmol/src/org/jmol/util line 77 FindBugs Problem (Normal Priority) M B RR: org.jmol.util.BinaryDocument.seek(long) ignore le résultat de java.io.DataInputStream.skipBytes(int) BinaryDocument.java Jmol/src/org/jmol/util line 133 FindBugs Problem (Normal Priority) M B RR: org.jmol.viewer.Eval.pmesh() ignore le résultat de java.io.BufferedReader.read(char[]) Eval.java Jmol/src/org/jmol/viewer line 9758 FindBugs Problem (Normal Priority) M B Se: La classe org.jmol.modelset.Atom définit le champ d'instance org.jmol.modelset.Atom.bonds non transient et non sérialisable Atom.java Jmol/src/org/jmol/modelset line 72 FindBugs Problem (Normal Priority) M B Se: La classe org.jmol.modelset.Atom définit le champ d'instance org.jmol.modelset.Atom.group non transient et non sérialisable Atom.java Jmol/src/org/jmol/modelset line 50 FindBugs Problem (Normal Priority) M B Se: org.jmol.adapter.smarter.SmarterJmolAdapter est stocké dans le champ non transient org.openscience.jmol.app.Jmol.modelAdapter Jmol.java Jmol/src/org/openscience/jmol/app line 189 FindBugs Problem (Normal Priority) M B Se: org.jmol.adapter.smarter.SmarterJmolAdapter est stocké dans le champ non transient org.openscience.jmol.app.Jmol.modelAdapter Jmol.java Jmol/src/org/openscience/jmol/app line 193 FindBugs Problem (Normal Priority) M B Se: org.jmol.adapter.smarter.SmarterJmolAdapter est stocké dans le champ non transient org.openscience.jmol.app.Jmol.modelAdapter Jmol.java Jmol/src/org/openscience/jmol/app line 196 FindBugs Problem (Normal Priority) M B Se: org.openscience.jmol.app.DisplayPanel$1 est stocké dans le champ non transient org.openscience.jmol.app.DisplayPanel.menuListener DisplayPanel.java Jmol/src/org/openscience/jmol/app line 265 FindBugs Problem (Normal Priority) M B Se: org.openscience.jmol.app.PreferencesDialog$1 est stocké dans le champ non transient org.openscience.jmol.app.PreferencesDialog.checkBoxListener PreferencesDialog.java Jmol/src/org/openscience/jmol/app line 667 FindBugs Problem (Normal Priority) M B SI: L'initialiseur statique de org.jmol.symmetry.Translation crée une instance avant que tous les champs static final soient alimentés HallInfo.java Jmol/src/org/jmol/symmetry line 490 FindBugs Problem (Normal Priority) M D DB: La méthode org.jmol.adapter.smarter.AtomSetCollection.applyAllSymmetry(int, int, int) utilise le même code pour deux branches AtomSetCollection.java Jmol/src/org/jmol/adapter/smarter line 627 FindBugs Problem (Normal Priority) M D DB: La méthode org.jmol.shapebio.BioShapeRenderer.setMads(int, boolean) utilise le même code pour deux branches BioShapeRenderer.java Jmol/src/org/jmol/shapebio line 282 FindBugs Problem (Normal Priority) M D DB: La méthode org.jmol.shapespecial.DrawRenderer.render2() utilise le même code pour deux branches DrawRenderer.java Jmol/src/org/jmol/shapespecial line 153 FindBugs Problem (Normal Priority) M D DB: La méthode org.openscience.jmol.app.Jmol.createMenu(String) utilise le même code pour deux branches Jmol.java Jmol/src/org/openscience/jmol/app line 1136 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.export._PovrayExporter.getHeader() _PovrayExporter.java Jmol/src/org/jmol/export line 83 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.minimize.Util.restorativeForceAndAngleRadians(Vector3d, Vector3d, Vector3d) Util.java Jmol/src/org/jmol/minimize line 259 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.util.JpegEncoder.WriteCompressedData(BufferedOutputStream, JpegInfo, DCT, Huffman) JpegEncoder.java Jmol/src/org/jmol/util line 112 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.util.JpegEncoder.WriteCompressedData(BufferedOutputStream, JpegInfo, DCT, Huffman) JpegEncoder.java Jmol/src/org/jmol/util line 113 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.util.JpegEncoder.WriteDHTHeader(int[], int[], BufferedOutputStream) JpegEncoder.java Jmol/src/org/jmol/util line 328 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.viewer.Eval.label(int) Eval.java Jmol/src/org/jmol/viewer line 4259 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.viewer.Eval.monitor() Eval.java Jmol/src/org/jmol/viewer line 4752 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.jmol.viewer.Eval.zoom(boolean) Eval.java Jmol/src/org/jmol/viewer line 5636 FindBugs Problem (Normal Priority) M D DLS: Alimentation à perte d'une variable locale dans la méthode org.openscience.jmol.app.PovrayDialog.goPressed() PovrayDialog.java Jmol/src/org/openscience/jmol/app line 546 FindBugs Problem (Normal Priority) M D Eq: org.jmol.symmetry.SymmetryOperation doesn't override javax.vecmath.Matrix4f.equals(Object) vecmath1.2-1.14.jar Jmol/jars line 1409 FindBugs Problem (Normal Priority) M D FE: Test d'égalité en virgule flottante dans org.jmol.viewer.Eval.rotate(boolean, boolean). Eval.java Jmol/src/org/jmol/viewer line 5101 FindBugs Problem (Normal Priority) M D ICAST: Le résultat d'une multiplication entière est transtypée en long dans org.jmol.export.image.GifEncoder$AdaptiveColorCollection.addRgb(int, int) GifEncoder.java Jmol/src/org/jmol/export/image line 145 FindBugs Problem (Normal Priority) M D ICAST: Résultat d'une division entière transtypé en nombre flottant à double précision dans org.jmol.shape.AxesRenderer.renderLabel(String, Font3D, float, float, float, float, float) AxesRenderer.java Jmol/src/org/jmol/shape line 146 FindBugs Problem (Normal Priority) M D ICAST: Résultat d'une division entière transtypé en nombre flottant à double précision dans org.jmol.shape.Text.setPosition(float) Text.java Jmol/src/org/jmol/shape line 257 FindBugs Problem (Normal Priority) M D ICAST: Résultat d'une division entière transtypé en nombre flottant à double précision dans org.jmol.viewer.TransformManager.getTranslationXPercent() TransformManager.java Jmol/src/org/jmol/viewer line 514 FindBugs Problem (Normal Priority) M D ICAST: Résultat d'une division entière transtypé en nombre flottant à double précision dans org.jmol.viewer.TransformManager.getTranslationYPercent() TransformManager.java Jmol/src/org/jmol/viewer line 518 FindBugs Problem (Normal Priority) M D IM: Un test d'impaire ne fonctionnera pas avec les négatifs dans org.jmol.shapebio.StrandsRenderer.render1() StrandsRenderer.java Jmol/src/org/jmol/shapebio line 62 FindBugs Problem (Normal Priority) M D IM: Un test d'impaire ne fonctionnera pas avec les négatifs dans org.jmol.symmetry.PointGroup.set(PointGroup, Atom[], BitSet, boolean, float, float) PointGroup.java Jmol/src/org/jmol/symmetry line 259 FindBugs Problem (Normal Priority) M D MF: La classe org.jmol.adapter.readers.more.PqrReader définit un champ qui masque le champ org.jmol.adapter.readers.more.PqrReader.fileType d'une classe mère PqrReader.java Jmol/src/org/jmol/adapter/readers/more line 52 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.jvxl.readers.ApbsReader.readAtomCountAndOrigin() ApbsReader.java Jmol/src/org/jmol/jvxl/readers line 55 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.jvxl.readers.CubeReader.readAtomCountAndOrigin() CubeReader.java Jmol/src/org/jmol/jvxl/readers line 53 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.jvxl.readers.VolumeFileReader.readExtraLine() VolumeFileReader.java Jmol/src/org/jmol/jvxl/readers line 202 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.jvxl.readers.VolumeFileReader.readVoxelVector(int) VolumeFileReader.java Jmol/src/org/jmol/jvxl/readers line 192 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.jvxl.readers.VolumeFileReader.skipData(int) VolumeFileReader.java Jmol/src/org/jmol/jvxl/readers line 378 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.shapesurface.Pmesh.getInt() Pmesh.java Jmol/src/org/jmol/shapesurface line 221 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.shapesurface.Pmesh.readPolygonCount() Pmesh.java Jmol/src/org/jmol/shapesurface line 264 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.shapesurface.Pmesh.readVertices() Pmesh.java Jmol/src/org/jmol/shapesurface line 245 FindBugs Problem (Normal Priority) M D NP: Dereference of the result of readLine() without nullcheck in org.jmol.shapesurface.Pmesh.readVertices() Pmesh.java Jmol/src/org/jmol/shapesurface line 253 FindBugs Problem (Normal Priority) M D NP: Déréférencement immédiat du résultat d'un readLine() dans org.jmol.jvxl.readers.XplorReader.readTitleLines() XplorReader.java Jmol/src/org/jmol/jvxl/readers line 102 FindBugs Problem (Normal Priority) M D NP: Lecture d'un champ jamais alimenté dans org.openscience.jmol.app.webexport.Orbitals.actionPerformed(ActionEvent) Orbitals.java Jmol/src/org/openscience/jmol/app/webexport line 247 FindBugs Problem (Normal Priority) M D NP: Possible déréférencement d'un pointeur null dans le chemin d'exception de org.openscience.jmol.app.webexport.Test.actionPerformed(ActionEvent) Test.java Jmol/src/org/openscience/jmol/app/webexport line 165 FindBugs Problem (Normal Priority) M D RCN: Test de nullité dans list d'une valeur préalablement déréférencée dans org.jmol.util.ZipUtil.getZipFileContentsAsBytes(InputStream, String[], int) ZipUtil.java Jmol/src/org/jmol/util line 121 FindBugs Problem (Normal Priority) M D RCN: Test de nullité dans org.jmol.shape.MeshRenderer.mesh d'une valeur préalablement déréférencée dans org.jmol.shape.MeshRenderer.setVariables() MeshRenderer.java Jmol/src/org/jmol/shape line 79 FindBugs Problem (Normal Priority) M D RCN: Test de nullité redondant sur une valeur non nulle dans org.jmol.adapter.readers.cifpdb.PdbReader.remark350() PdbReader.java Jmol/src/org/jmol/adapter/readers/cifpdb line 362 FindBugs Problem (Normal Priority) M D RCN: Test de nullité redondant sur une valeur non nulle dans org.jmol.viewer.Eval.setVariable(int, int, String, boolean) Eval.java Jmol/src/org/jmol/viewer line 7296 FindBugs Problem (Normal Priority) M D RCN: Test de nullité redondant sur une valeur non nulle dans org.jmol.viewer.FileManager.getDefaultDirectory(String) FileManager.java Jmol/src/org/jmol/viewer line 604 FindBugs Problem (Normal Priority) M D REC: La méthode org.jmol.viewer.Eval.checkContinue() intercepte Exception, mais Exception n'est pas lancé dans le bloc try/catch et RuntimeException n'est pas appelé Eval.java Jmol/src/org/jmol/viewer line 702 FindBugs Problem (Normal Priority) M D REC: La méthode org.jmol.viewer.FrameRenderer.generateOutput(String, Graphics3D, ModelSet, String) intercepte Exception, mais Exception n'est pas lancé dans le bloc try/catch et RuntimeException n'est pas appelé FrameRenderer.java Jmol/src/org/jmol/viewer line 120 FindBugs Problem (Normal Priority) M D REC: La méthode org.openscience.jmol.app.AtomSetChooser.actionPerformed(ActionEvent) intercepte Exception, mais Exception n'est pas lancé dans le bloc try/catch et RuntimeException n'est pas appelé AtomSetChooser.java Jmol/src/org/openscience/jmol/app line 499 FindBugs Problem (Normal Priority) M D REC: La méthode org.openscience.jmol.app.PreferencesDialog.initializeProperties() intercepte Exception, mais Exception n'est pas lancé dans le bloc try/catch et RuntimeException n'est pas appelé PreferencesDialog.java Jmol/src/org/openscience/jmol/app line 588 FindBugs Problem (Normal Priority) M D SA: Double assignment of field PdbReader.modelNumber in org.jmol.adapter.readers.cifpdb.PdbReader.readAtomSetCollection(BufferedReader) PdbReader.java Jmol/src/org/jmol/adapter/readers/cifpdb line 125 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.jmol.export.dialog.Dialog.defaultChoice depuis la méthode d'une instance org.jmol.export.dialog.Dialog.getImageFileNameFromDialog(JmolViewer, String, String, String[], String[], int, int) Dialog.java Jmol/src/org/jmol/export/dialog line 247 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.jmol.export.dialog.Dialog.qualityJPG depuis la méthode d'une instance org.jmol.export.dialog.Dialog$QualityListener.stateChanged(ChangeEvent) Dialog.java Jmol/src/org/jmol/export/dialog line 324 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.openscience.jmol.app.Jmol.buttonRotate depuis la méthode d'une instance org.openscience.jmol.app.Jmol.createToolbarButton(String) Jmol.java Jmol/src/org/openscience/jmol/app line 944 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.openscience.jmol.app.Jmol.menuFile depuis la méthode d'une instance org.openscience.jmol.app.Jmol$MyStatusListener.setCallbackFunction(String, String) Jmol.java Jmol/src/org/openscience/jmol/app line 1741 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.openscience.jmol.app.Jmol.menuStructure depuis la méthode d'une instance new org.openscience.jmol.app.Jmol(Splash, JFrame, Jmol, int, int, String, Point) Jmol.java Jmol/src/org/openscience/jmol/app line 283 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.openscience.jmol.app.Jmol.menuStructure depuis la méthode d'une instance org.openscience.jmol.app.Jmol$MyStatusListener.setCallbackFunction(String, String) Jmol.java Jmol/src/org/openscience/jmol/app line 1740 FindBugs Problem (Normal Priority) M D ST: Ecriture d'un champ statique org.openscience.jmol.app.webexport.WebExport.historyFile depuis la méthode d'une instance new org.openscience.jmol.app.webexport.WebExport(JmolViewer, HistoryFile) WebExport.java Jmol/src/org/openscience/jmol/app/webexport line 77 FindBugs Problem (Normal Priority) M D UwF: Champ jamais écrit : org.jmol.export.image.AviCreator.errorMsg AviCreator.java Jmol/src/org/jmol/export/image line 140 FindBugs Problem (Normal Priority) M D UwF: Champ jamais écrit : org.openscience.jmol.app.PovrayDialog.outputFormatCheck PovrayDialog.java Jmol/src/org/openscience/jmol/app line 692 FindBugs Problem (Normal Priority) M D UwF: Champ jamais écrit : org.openscience.jmol.app.webexport.Orbitals.appletPath Orbitals.java Jmol/src/org/openscience/jmol/app/webexport line 77 FindBugs Problem (Normal Priority) M D UwF: Champ jamais écrit : org.openscience.jmol.app.webexport.WebPanel.editorScrollPane WebPanel.java Jmol/src/org/openscience/jmol/app/webexport line 271 FindBugs Problem (Normal Priority) M D UwF: Le champ org.jmol.viewer.FileManager$DOMOpenThread.errorMessage est uniquement mis à null FileManager.java Jmol/src/org/jmol/viewer line 780 FindBugs Problem (Normal Priority) M M LI: Incorrect lazy initialization and update of static field org.jmol.symmetry.SpaceGroup.canonicalSeitzList in org.jmol.symmetry.SpaceGroup.dumpCanonicalSeitzList() SpaceGroup.java Jmol/src/org/jmol/symmetry line 344 FindBugs Problem (Normal Priority) M M Wa: wait() en dehors d'une boucle dans org.jmol.viewer.RepaintManager.requestRepaintAndWait() RepaintManager.java Jmol/src/org/jmol/viewer line 183 FindBugs Problem (Normal Priority) M P SBSC: La méthode org.jmol.viewer.FileManager.fixPath(String) concatène des chaînes au moyen de + en boucle FileManager.java Jmol/src/org/jmol/viewer line 621 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.adapter.smarter.SmarterJmolAdapter$AtomIterator.atomSetCollection SmarterJmolAdapter.java Jmol/src/org/jmol/adapter/smarter line 480 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.adapter.smarter.SmarterJmolAdapter$BondIterator.atomSetCollection SmarterJmolAdapter.java Jmol/src/org/jmol/adapter/smarter line 536 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.export.image.GifEncoder$AdaptiveColorCollection.rgb GifEncoder.java Jmol/src/org/jmol/export/image line 140 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.export.image.GifEncoder$ColorItem.index GifEncoder.java Jmol/src/org/jmol/export/image line 112 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.export.image.GifEncoder$ColorItem.isTransparent GifEncoder.java Jmol/src/org/jmol/export/image line 113 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.export.image.GifEncoder$ColorItem.rgb2 GifEncoder.java Jmol/src/org/jmol/export/image line 110 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.dmax MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 125 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.dmean MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 126 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.dmin MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 124 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.ispg MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 128 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.nlabel MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 139 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.nsymbt MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 129 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.nxStart MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 103 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.nyStart MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 104 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.nzStart MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 105 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.MrcBinaryReader$MrcHeader.rms MrcBinaryReader.java Jmol/src/org/jmol/jvxl/readers line 138 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.atomIndex Parameters.java Jmol/src/org/jmol/jvxl/readers line 181 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.isAngstroms Parameters.java Jmol/src/org/jmol/jvxl/readers line 203 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.isSilent Parameters.java Jmol/src/org/jmol/jvxl/readers line 141 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.logCompression Parameters.java Jmol/src/org/jmol/jvxl/readers line 139 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.logCube Parameters.java Jmol/src/org/jmol/jvxl/readers line 140 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.psi_ptsPerAngstrom Parameters.java Jmol/src/org/jmol/jvxl/readers line 505 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.minimize.forcefield.Calculations.ff Calculations.java Jmol/src/org/jmol/minimize/forcefield line 73 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.modelset.Model.firstMolecule ModelCollection.java Jmol/src/org/jmol/modelset line 1523 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.modelset.ModelCollection$Structure.typeName ModelCollection.java Jmol/src/org/jmol/modelset line 912 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.shapebio.Strands.isMesh MeshRibbon.java Jmol/src/org/jmol/shapebio line 31 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.symmetry.PointGroup$Operation.typeIndex PointGroup.java Jmol/src/org/jmol/symmetry line 995 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.symmetry.UnitCell.isPrimitive UnitCell.java Jmol/src/org/jmol/symmetry line 343 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.util.Huffman.NumOfACTables JpegEncoder.java Jmol/src/org/jmol/util line 838 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.jmol.util.Huffman.NumOfDCTables JpegEncoder.java Jmol/src/org/jmol/util line 837 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.openscience.jmol.app.webexport.JmolInstance.pictIsScratchFile JmolInstance.java Jmol/src/org/openscience/jmol/app/webexport line 70 FindBugs Problem (Normal Priority) M P UrF: Champ inutilisé : org.openscience.jmol.app.webexport.JmolInstance.viewer JmolInstance.java Jmol/src/org/openscience/jmol/app/webexport line 49 FindBugs Problem (Normal Priority) M P UuF: Champ inutilisé : org.jmol.applet.Jmol.languagePath Jmol.java Jmol/src/org/jmol/applet line 149 FindBugs Problem (Normal Priority) M P UuF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.aniosU Parameters.java Jmol/src/org/jmol/jvxl/readers line 322 FindBugs Problem (Normal Priority) M P UuF: Champ inutilisé : org.jmol.jvxl.readers.Parameters.qm_nAtoms Parameters.java Jmol/src/org/jmol/jvxl/readers line 577 FindBugs Problem (Normal Priority) M P UuF: Champ inutilisé : org.jmol.viewer.Function.pt0 Function.java Jmol/src/org/jmol/viewer line 30 FindBugs Problem (Normal Priority) M P UuF: Champ inutilisé : org.jmol.viewer.Function.returnValue Function.java Jmol/src/org/jmol/viewer line 40 FindBugs Problem (Normal Priority) M V MS: org.jmol.shape.Object2d.hAlignNames devrait être package protected Object2d.java Jmol/src/org/jmol/shape line 18 FindBugs Problem (Normal Priority) M V MS: org.jmol.shape.Object2d.vAlignNames devrait être package protected Object2d.java Jmol/src/org/jmol/shape line 26 FindBugs Problem (Normal Priority) M V MS: org.jmol.util.Logger.debugging n'est pas final et n'est pas protégé face à du code malveillant Logger.java Jmol/src/org/jmol/util line 54 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.altArgbsCpk devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 923 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.argbsChainAtom devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 1860 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.argbsChainHetero devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 1894 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.argbsFormalCharge devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 1936 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.argbsHbondType devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 349 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.argbsStructure devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 1791 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.predefinedStatic devrait être à la fois final et package protected JmolConstants.java Jmol/src/org/jmol/viewer line 2602 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.predefinedVariable devrait être à la fois final et package protected JmolConstants.java Jmol/src/org/jmol/viewer line 2591 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.proteinStructureNames devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 1765 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.shapeToks devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 2788 FindBugs Problem (Normal Priority) M V MS: org.jmol.viewer.JmolConstants.vanderwaalsMars devrait être package protected JmolConstants.java Jmol/src/org/jmol/viewer line 975 FindBugs Problem (Normal Priority) M X OBL: Method org.jmol.export.dialog.HistoryFile.load() may fail to clean up stream or resource of type java.io.InputStream HistoryFile.java Jmol/src/org/jmol/export/dialog line 349 FindBugs Problem (Normal Priority) M X OBL: Method org.jmol.export.dialog.HistoryFile.save() may fail to clean up stream or resource of type java.io.OutputStream HistoryFile.java Jmol/src/org/jmol/export/dialog line 363 FindBugs Problem (Normal Priority) M X OBL: Method org.openscience.jmol.app.PreferencesDialog.save() may fail to clean up stream or resource of type java.io.OutputStream PreferencesDialog.java Jmol/src/org/openscience/jmol/app line 569 FindBugs Problem (Normal Priority) M X OBL: Method org.openscience.jmol.app.webexport.WebPanel.writeFileBytes(String, byte[]) may fail to clean up stream or resource of type java.io.OutputStream WebPanel.java Jmol/src/org/openscience/jmol/app/webexport line 573 FindBugs Problem (Normal Priority) |