[Jmol-developers] [ jmol-Bugs-1663435 ] symlink detection in jmol.sh broken for relative links

[SourceForge.net <no...@so...>]

Bugs item #1663435, was opened at 2007-02-19 13:35
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=1663435&group_id=23629

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Application
Group: v11
>Status: Closed
>Resolution: Works For Me
Priority: 8
Private: No
Submitted By: Stuart Prescott (themill)
Assigned to: Egon Willighagen (egonw)
Summary: symlink detection in jmol.sh broken for relative links

Initial Comment:
I just unpacked the jmol tarball into /usr/local/share/jmol/ and then to put jmol in my path I did this:

cd /usr/local/bin

ln -s ../share/jmol/jmol.sh ./jmol

And then jmol didn't work:

           Jmol could not find its installed files.

If, however, I did the following:

ln -s /usr/local/share/jmol/jmol.sh ./jmol

then it works fine.

So.... two suggestions for you:

* in the jmol script, also search for /usr/local/share as well as /usr/share. /usr/share should only be touched by the distro packaging system (apt, yum, emerge etc) while /usr/local/share is for the sysadmin to monkey with.

* in the jmol.sh script, change your regexp to be '/.*' not '.*/.*' as what you have currently just looks for any slash in the path not necessarily one at the start

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2008-03-15 16:33

Message:
Logged In: YES 
user_id=25678
Originator: NO

I looked at the problem, and both symlinks work for me. Moveover, I cannot
find a trace of code in the .sh file that involves a  hardcoded usr/share
directory.

About the second suggestion... I don't quite get what why not looking for
any slash is not sufficient... as it works for me, I'm not eager to change
the code.

Please reopen this bug, if any symlink to the jmol.sh still does not work
for you.

Tested on Ubuntu hardy GNU/Linux.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=1663435&group_id=23629