[Jmol-developers] Re: 10.1 punch list - auxiliaryInfo

[Miguel <mi...@jm...>]

> Review prior to 10.1 release
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
=5Bsnip=5D
> Reader/File related
> -------------------
=5Bsnip=5D
> r4624,r4625,r4630 - auxiliaryInfo
>
> r4623,r4635,r4640 - SpartanSmolReader

OK r4623 was reintroduced in r4854. The JUnit tests run fine on all of th=
e
SpartanSmol files.


I uncovered a problem when looking into auxiliaryInfo and the other reade=
r
changes that depend upon it ...

The problem is actually with getAtomSetCollectionProperties and
getAtomSetProperties ... those entry points were intended to be used for
passing more complicated information from the Readers to the Viewer.

Bob pointed out that he could not use getAtomSetCollectionProperties
because he needed to pass more complicated data structures. So he created=

auxiliaryInfo methods that use Hashtable.

This is something that we need to take a look at and consider. These two
things need to be consolidated ... because they are trying to provide the=

same functionality.

This is also related to the API and data structures that we use to
exchange information between the viewer and JavaScript or the viewer and
Java.

I strongly suspect that the Hashtable solution is the right one and that
we will replace the use of java.util.Properties in org.jmol.api.* with
java.util.Hashtable. This will need to be reviewed after the 10.1 release=
.

So, this auxiliaryInfo API enhancement will not make it into the 10.1
release. Nor will the reader changes (SpartanSmol + Gaussian ?) that
depend upon it.

These are revisions r4624,r4625,r4630,r4635,r4640


Miguel