[Jmol-developers] [ jmol-Bugs-1035673 ] missing null-pointer check causes NPE

[SourceForge.net <no...@so...>]

Bugs item #1035673, was opened at 2004-09-27 15:21
Message generated for change (Comment added) made by migueljmol
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=1035673&group_id=23629

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: David L Jung (djung)
Assigned to: Miguel (migueljmol)
Summary: missing null-pointer check causes NPE

Initial Comment:
In the file
org/openscience/jmol/app/jMolResourcehandler.java
the constructor does this:
     generalResourceBundle = new
PropertyResourceBundle(getClass()
        .getClassLoader()    
.getResourceAsStream("org/openscience/jmol/Properties/Jmol-resources.properties"));

However, getClassLoader() can legitimately return null
(according to the SDK docs) - and does on some systems
(including mine).

The resulting NPE stops JMol from starting.

Cheers,
-David.



----------------------------------------------------------------------

>Comment By: Miguel (migueljmol)
Date: 2004-12-13 11:29

Message:
Logged In: YES 
user_id=1050060

No feedback. 
Implementation was changed to:
      generalResourceBundle =
        new
PropertyResourceBundle(getClass().getResourceAsStream(t));

Has not caused problems for others ... might have fixed this
problem


----------------------------------------------------------------------

Comment By: Miguel (migueljmol)
Date: 2004-09-27 15:56

Message:
Logged In: YES 
user_id=1050060

Hmmm ... that is some old code. 

I made a change and just checked it into CVS. Check out the current 
source, rebuild, and let me know if it does not work. 

Q: What kind of system are you running on? 


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=1035673&group_id=23629