Menu ▾ ▴

#32 JmmDNS improvements

pending-fixed
Pierre Frisch
None
5
2012-06-07
2012-06-07
Trejkaz
No

Tracking down my own issue in 3525349, this patch fixes some issues and improves things a little but without fixing it...

Fix #1: When JmmDNS started, it wasn't scanning for network interfaces up-front. Now it does.

Fix #2: The timeout was being applied incorrectly - if you had N network interfaces it would apply a timeout of up to N times your requested timeout.

Fix #3: The executor wasn't being shut down in the event of an error, causing threads to hang around forever.

Discussion

  • Trejkaz

    Trejkaz - 2012-06-07

    patch

     
    jmmdns.patch

  • Pierre Frisch

    Pierre Frisch - 2012-06-07

    commit -m "JmmDNS improvements - ID: 3532626" /Users/pierre/Projects/workspace/jmdns/CHANGELOG.txt /Users/pierre/Projects/workspace/jmdns/src/test/java/javax/jmdns/test/JmmDNSTest.java
    Sending /Users/pierre/Projects/workspace/jmdns/CHANGELOG.txt
    Sending /Users/pierre/Projects/workspace/jmdns/src/test/java/javax/jmdns/test/JmmDNSTest.java
    Transmitting file data ...
    Committed revision 343.

     

  • Pierre Frisch

    Pierre Frisch - 2012-06-07
    • assigned_to: nobody --> spearway
    • status: open --> pending-fixed
     

  • Pierre Frisch

    Pierre Frisch - 2012-06-07

    Sorry my mistake

    commit -m "JmmDNS improvements - ID: 3532626" /Users/pierre/Projects/workspace/jmdns/src/main/java/javax/jmdns/impl/JmmDNSImpl.java /Users/pierre/Projects/workspace/jmdns/src/test/java/javax/jmdns/test/JmmDNSTest.java
    Sending /Users/pierre/Projects/workspace/jmdns/src/main/java/javax/jmdns/impl/JmmDNSImpl.java
    Sending /Users/pierre/Projects/workspace/jmdns/src/test/java/javax/jmdns/test/JmmDNSTest.java
    Transmitting file data ...
    Committed revision 344.