Re: [Jfs-discussion] [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into h
Brought to you by:
blaschke-oss,
shaggyk
From: Trond M. <tro...@fy...> - 2007-08-06 19:05:09
|
On Mon, 2007-08-06 at 20:28 +0200, Miklos Szeredi wrote: > Your patch is changing the API in a very unsafe way, since there will > be no error or warning on an unconverted fs. And that could lead to > security holes. > > If we would rename the setattr method to setattr_new as well as > changing it's behavior, that would be fine. But I guess we do not > want to do that. Which "unconverted fses"? If we're talking out of tree stuff, then too bad: it is _their_ responsibility to keep up with kernel changes. Trond |