[Jfs-discussion] [PATCH] 2.5.29: Oops at boot after mount of root fs (JFS)
Brought to you by:
blaschke-oss,
shaggyk
From: Dave K. <sh...@au...> - 2002-07-29 18:22:43
|
On Monday 29 July 2002 10:16, Axel Siebenwirth wrote: > Hi, > > I get an oops during boot of 2.5.29. Since I have problems with JFS I > guessed it might be related to JFS. It happens right after rw mount > of my jfs root filesystem. At another attempt to boot not the rm > process oops but mount itself oopsed. JFS had two incorrect calls to d_delete in jfs_rmdir and jfs_unlink. They were needed in the 2.2 kernel, and somehow they didn't do any apparent harm until now. Here is that patch I sent to Linus: # This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.511 -> 1.512 # fs/jfs/namei.c 1.13 -> 1.14 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 02/07/29 sh...@kl... 1.512 # Remove d_delete call from jfs_rmdir and jfs_unlink # # jfs_rmdir and jfs_unlink have always called d_delete, but it hasn't # caused a problem until 2.5.28. The call is an artifact of the 2.2 # kernel, which had gone unnoticed in 2.4 and 2.5. # -------------------------------------------- # diff -Nru a/fs/jfs/namei.c b/fs/jfs/namei.c --- a/fs/jfs/namei.c Mon Jul 29 09:18:53 2002 +++ b/fs/jfs/namei.c Mon Jul 29 09:18:53 2002 @@ -399,8 +399,6 @@ IWRITE_UNLOCK(dip); - d_delete(dentry); - out2: free_UCSname(&dname); @@ -542,8 +540,6 @@ } IWRITE_UNLOCK(dip); - - d_delete(dentry); out1: free_UCSname(&dname); |