[Jfs-patches] [PATCH 7/9] missing unlock in jfs_quota_write()
Brought to you by:
blaschke-oss,
shaggyk
|
From: <sh...@li...> - 2009-06-17 15:21:07
|
commit 9c83633ad38138855181af6936e8ac570ef7e2cb
Author: Dan Carpenter <er...@gm...>
Date: Tue Apr 7 14:48:16 2009 +0300
missing unlock in jfs_quota_write()
We should unlock &inode->i_mutex on the error path. This bug was
in ext2_quota_write(). I sent a patch to them today as well.
Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <er...@gm...>
Signed-off-by: Dave Kleikamp <sh...@li...>
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index 6f21adf..d9b0e92 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -720,8 +720,10 @@ static ssize_t jfs_quota_write(struct super_block *sb, int type,
blk++;
}
out:
- if (len == towrite)
+ if (len == towrite) {
+ mutex_unlock(&inode->i_mutex);
return err;
+ }
if (inode->i_size < off+len-towrite)
i_size_write(inode, off+len-towrite);
inode->i_version++;
|