[jfreechart-dev] [ jfreechart-Bugs-1565168 ] crosshair is incorrectly positioned

[SourceForge.net <no...@so...>]

Bugs item #1565168, was opened at 2006-09-25 15:34
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=1565168&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Sergei Ivanov (sergei_ivanov)
Assigned to: David Gilbert (mungady)
Summary: crosshair is incorrectly positioned

Initial Comment:
Crosshair is not positioned correctly when one of the 
axes is not locked to data. In this case it is snapped 
to the "closest to zero" value on the other axis.

>From the implementation standpoint, it is caused by 
the way updateCrosshairX/Y methods in CrosshairState 
class are called.

The supplied patch resolves the problem and also fixes 
crosshair painting and positioning for ContourPlot.

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2007-02-28 13:52

Message:
Logged In: YES 
user_id=112975
Originator: NO

OK, closing.

----------------------------------------------------------------------

Comment By: Sergei Ivanov (sergei_ivanov)
Date: 2007-02-27 09:49

Message:
Logged In: YES 
user_id=1606022
Originator: YES

I think this ussue may be closed now.

----------------------------------------------------------------------

Comment By: Sergei Ivanov (sergei_ivanov)
Date: 2006-10-19 20:31

Message:
Logged In: YES 
user_id=1606022

The reason behind API modification is simple -- I wanted 
to come up with a "clean" fix, which would be preserving 
the existing logic. Even though one of the data spaces is 
actually never used, I decided to support both modes, 
which led to passing extra parameters into the methods.

The reason behind ContourPlot modification is simple - it 
was affected by the modified API. I brought it in sync 
with my changes and slightly optimised along the way.

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2006-10-13 15:19

Message:
Logged In: YES 
user_id=112975

I've committed a fix for the crosshair positioning, for
inclusion in the 1.0.3 release.

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2006-10-13 11:08

Message:
Logged In: YES 
user_id=112975

Thanks for the report.  I can see the problem, which is
caused by the anchorX and anchorY values never being
initialised.

I can't use your patch as is, since it modifies the API, and
I'm trying to avoid that in the 1.0.x series of JFreeChart.
 Also, there is no need to check (for the single axis cases)
whether we are in data space or Java2D space, since the
result will be the same either way (it only matters when you
are looking at both axes, where the scales might differ a
lot).  I'll come up with an alternative fix.

I didn't look at the ContourPlot stuff yet (although if you
are using ContourPlot, please take a look at the
XYBlockRenderer class in the "experimental" packages in the
1.0.2 release - it allows similar kinds of charts, but
within the standard XYPlot framework.  It still needs work,
but comments are welcome).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=1565168&group_id=15494