[jfreechart-dev] [ jfreechart-Bugs-1926517 ] Discrepancy between CombinedDomain*Plot classes

[SourceForge.net <no...@so...>]

Bugs item #1926517, was opened at 2008-03-26 13:42
Message generated for change (Comment added) made by richardwest
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=1926517&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Closed
Resolution: None
Priority: 7
Private: No
Submitted By: Richard West (richardwest)
Assigned to: David Gilbert (mungady)
Summary: Discrepancy between CombinedDomain*Plot classes

Initial Comment:
I am reworking my combined domain and range plot classes (see https://sourceforge.net/tracker/?func=detail&atid=315494&aid=1924543&group_id=15494 (patch 1924543)), and I have noticed a discrepancy between the CombinedDomainCategoryPlot and CombinedDomainXYPlot.  In the latter, the getDataRange(ValueAxis) method has been defined to return the combined rnage of all the subplots.  In the former, the getDataRange(ValueAxis) method is not defined, so the CombinedDomainCategoryPlot relies on the CategoryPlot class' version.  The result is that calling getDataRange on a CombinedDomainCategoryPlot returns a default axis range of [0.0, 1.05].

This discrepancy can be fixed by either adding CombinedDomainXYPlot's getDataRange(ValueAxis), appropriately modified, to CombinedDomainCategoryPlot or remove the override from CombinedDomainXYPlot. While I do not have strong feelings as to which course of action should be taken, I do feel strongly that this should be fixed.  The argument for the former solution is backwards compatibility in case people have relied on CombinedDomainXYPlot's getDataRange(ValueAxis).  The argument for the latter solution is 'correctness' since the combined plot does not really have a data range per se.

I will be updating the patch with my combined domain and range plot classes, and I will be noting this bug in the comments.

----------------------------------------------------------------------

>Comment By: Richard West (richardwest)
Date: 2008-03-27 12:14

Message:
Logged In: YES 
user_id=1788593
Originator: YES

I guess this makes sense.  For consistency, I shall have both
CombinedCategoryPlot and CombinedXYPlot (see the aforementioned patch)
override the getDataRange method.  This will prevent problems if the
CommonDomain*Plot classes ever start inforcing that only the domain axis
can call the getDataRange method.

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2008-03-27 09:45

Message:
Logged In: YES 
user_id=112975
Originator: NO

Hi Richard,

I think the code is correct, although not very clear.  First, these
methods are only public so they can be accessed by the axis classes that
need to determine their 'auto range'.  It isn't really intended that these
methods be called by user code.  Second, although the method signature is
designed so that it can be called for either a domain axis or a range axis,
in the case of the CombinedDomainXYPlot it will only ever be called for a
domain axis (because, as you spotted, it doesn't really make sense to find
the data range for the subplots against the range axes since these are all
independent).  That's why, for the CombinedDomainCategoryPlot, the method
was never overridden (it's unnecessary, because the shared domain axis is a
CategoryAxis, which has no 'auto range' to calculate...there may well be
bugs relating to aggregating the categories from the subplots, but that's
another issue).

So to "fix" this bug, I've committed some additional javadoc comments that
perhaps make this clearer.  I was also tempted to throw some exceptions if
the methods were called with an invalid axis, but maybe that would just be
an annoyance for anyone who is already using these methods.

Sorry for the confusing code...I hope I've explained it well enough.

Regards,

Dave

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=1926517&group_id=15494