Re: [Jflex-devel] Minimum build JDK: 6->7 ?
The fast lexer generator for Java
Brought to you by:
lsf37,
steve_rowe
From: Gerwin K. <ge...@do...> - 2017-03-12 22:33:10
|
Hi Steve, > Done. Cool! > One question: previously the docs stated that the runtime Java version was 1.5, but I removed that, since the current build requires 1.7. Do you want to put it back? I.e. is there some magic that allows the distributed binary to be built with an older version of Java? The runtime and compile time dependencies are often different. With the latest change, I think it they are both on 1.7 now, though. >>> It’d be nice to make the test suite aware of JDK version at the points where it is sensitive to that. If I remember correctly the failure was just a different output order of a Hashtable or similar. >> >> What sort of awareness are you thinking of? Allowing only a single version of the JDK? Or switching between expected output depending on JDK version? Or…? > > I’d appreciate your thoughts on this ^^. Haven’t completely thought this through yet, but I maybe something along the lines of making the test script aware that there could be different outputs for different JDK and even OS versions, which all are correct. I.e. if there is xxx-flex.output-jdk_v_x_y-osv and it matches the current jdk/os then it’d prefer that over xxx-flex.output (and xxx-flex.output-jdk_v_x_y-osv over xxx-flex.output-jdk_v_x_y if it exists). The alternative would be to try and make the test output strictly platform independent, e.g. sort the key when we dump tables and similar things. Wouldn’t help, though, if the interpretation of things like isJavaIdentifierStart change between jdk versions. Cheers, Gerwin |