|
From: Régis D. <re...@de...> - 2015-04-19 18:30:27
|
Thanks for the pointer, I'll have a look. There is another minor glitch I ran into: for done browser window width, the content is not collapsed in the menu, yet there isn't enough discs abd and the github logo goes on its own line. Le jeu. 16 avr. 2015 11:00, Gerwin Klein <Ger...@ni...> a écrit : > Thanks, makes sense to just use #content. > > I’ve merged the pull requests and can deploy later today when I have a > better internet connection. > > There is a problem with the fixed navbar that I also ran into > previously: when clicking a link like #content, the browser will set that > to the top of the page, ignoring the body offset, so that the target is > partially obscured by the nav bar. This trick seems to solve it: > > > http://stackoverflow.com/questions/18948440/when-navigating-to-id-element-is-hidden-under-fixed-position-header/18948554#18948554 > > Should we do that, or do you know a better solution? > > Cheers, > Gerwin > > > On 15 Apr 2015, at 11:16 pm, Régis Décamps <re...@de...> wrote: > > Thanks. I don't know why I haven't initially made a pull request. > > Le mer. 15 avr. 2015 à 16:15, Gerwin Klein <kl...@cs...> a > écrit : > >> Had some unexpected free time: looks very nice! >> >> Two small issues: the brand link in the navbar still goes to >> http://jflex.de. That made sense when it was always labeled `jflex.de`, >> but now it’s the title of the page, so we should link to the top of the >> current page instead. >> > > Good point. Done in > https://github.com/regisd/jflex-web/commit/ca49d6f3cf98e131a07d8b6fce459d9b467b5625 > > >> Related to that, the #top anchor seems to have disappeared. It’s used >> in the page footer to navigate up again (mostly only useful on mobiles and >> small screens). >> > > It wasn't removed. > > But, it can actually be replaced > https://github.com/regisd/jflex-web/commit/53ee94d1c96e60a89e4a108ef3afd8a0553ff8b5 > > -- > Régis > > >> On 15 Apr 2015, at 9:49 am, Gerwin Klein <kl...@cs...> wrote: >> >> Sounds cool. I’m travelling again, so might be a few days before I can >> have a closer look. >> >> Cheers, >> Gerwin >> >> On 13 Apr 2015, at 9:45 pm, Régis Décamps <re...@de...> wrote: >> >> Hello Gerwin and others, >> >> I tried to give a touch of material design to jflex.de. That's mainly >> the use of headers for now (self implement with jquery, there is no new >> dependency) >> >> I also chose new colors from the palette >> <http://www.google.ch/design/spec/style/color.html#color-color-palette>: >> indogo and orange. >> >> The patch is in branch "material" (oops, the same branch also fixes >> some issues with the titles). >> >> -- >> Régis >> PJ: Screenshot top of page, after a scroll >> >> >> > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live > exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF_______________________________________________ > Jflex-devel mailing list > Jfl...@li... > https://lists.sourceforge.net/lists/listinfo/jflex-devel > > > > ------------------------------ > > The information in this e-mail may be confidential and subject to legal > professional privilege and/or copyright. National ICT Australia Limited > accepts no liability for any damage caused by this email or its attachments. > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live > exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF_______________________________________________ > Jflex-devel mailing list > Jfl...@li... > https://lists.sourceforge.net/lists/listinfo/jflex-devel > |
