[Jettylauncher-plugin] [ jettylauncher-Bugs-1740768 ] Patch for jetty6 support

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Bugs item #1740768, was opened at 2007-06-21 10:23
Message generated for change (Settings changed) made by eelco12
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=682377&aid=1740768&group_id=118870

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Jan Bartel (janb)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for jetty6 support

Initial Comment:
I've done a patch for the jettylauncher to run with jetty6. It's attached to this issue.

It would be great if someone with commit access on this project could apply it and make a release (assuming of course, you find the patch acceptable).

If there are any questions/clarifications/fixes, please contact me, probably best via the jetty mailing lists: jet...@so....

----------------------------------------------------------------------

Comment By: mtadashi (mtadashi)
Date: 2007-10-01 18:22

Message:
Logged In: YES 
user_id=1307500
Originator: NO

I have been waiting for Jetty6 support for a long time. This patch is
cool! Then I applied the patch and published on the site,
http://dbpowder.sourceforge.net/etc/jettylauncher6/updates/ .
It seems to run correctly. Jetty6 is much comfortable than Jetty5.

Much discussion may be required how to utilize the patch, however, there
must be many persons who are longing for Jetty6 support. If you don't mind,
please let me keep published.
When Jetty6 support is released, I'll stop publishing this.

----------------------------------------------------------------------

Comment By: Eelco Hillenius (eelco12)
Date: 2007-09-27 07:34

Message:
Logged In: YES 
user_id=820266
Originator: NO

I haven't been part of these discussions, but I'm kind of officially
retired from the project. In a few months I might finally have some time to
create a new plugin from scratch; one that packages Jetty 6 and doesn't
require further setup. Until then, I'm too busy with Wicket, my day
project, writing a book and planning my wedding. Sorry :-)

Jan, if you're interested in getting commit access, I'm sure the others
would agree that that would be a good idea.

----------------------------------------------------------------------

Comment By: Jan Bartel (janb)
Date: 2007-09-27 07:01

Message:
Logged In: YES 
user_id=45251
Originator: YES

I've had some discussions in the past weeks with the jettylauncher team
and I believe they were in the process of applying the patch. I'm not sure
of the current status - perhaps a team member could update us?

regards
Jan

----------------------------------------------------------------------

Comment By: Oliver Weichhold (oweichhold)
Date: 2007-09-25 00:45

Message:
Logged In: YES 
user_id=1115017
Originator: NO

Has anyone got the plugin to compile/install and work using the patch? 

----------------------------------------------------------------------

Comment By: Danilo Tuler (tuler)
Date: 2007-09-24 18:54

Message:
Logged In: YES 
user_id=28121
Originator: NO

Hi Andrew,
I'm sending the binaries to your email, although I do not think it's a
good idea to publish these binaries in an alternate public location. Leave
the release to the official team.
I'm sure Jan is trying to make the patch into the CVS and make a public
release ASAP.
I think there is some effort coming from Webtide Jetty team, am I right
Jan?

Regards.

----------------------------------------------------------------------

Comment By: Andrew McGregor (mcgregorandrew)
Date: 2007-09-24 07:08

Message:
Logged In: YES 
user_id=593351
Originator: NO

Hello Jan/Danilo,

If you can email me the rebuilt jar files, I'd be happy to host them on
our file server and post a link here. I have no experience rebuilding
plugins and I was hoping not to have to figure out how to do this....

        Regards,
                   Andrew (mcg...@ya...)

----------------------------------------------------------------------

Comment By: Danilo Tuler (tuler)
Date: 2007-09-22 18:34

Message:
Logged In: YES 
user_id=28121
Originator: NO

Jan,

Thank you for the patch.
It's working fine with me, Eclipse 3.3, Jetty 6.1.5, JDK 1.6.

For those who could not make it work, just a few tips.
1) Checkout projects from CVS;
2) Apply the patch using Eclipse Team / Apply Patch...
3) Export plugin, do not export as JAR, export as folder;
4) regenerate runner.jar using Export...

-- Danilo

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-09-21 16:26

Message:
Logged In: NO 

Does anyone have an update on this?  I can't get the patch to run either
and would like to use Jetty 6 in Eclipse.  Thanks!

----------------------------------------------------------------------

Comment By: Jan Bartel (janb)
Date: 2007-08-06 04:03

Message:
Logged In: YES 
user_id=45251
Originator: YES

I'm having difficulty posting this to Michael, so I'm cutting and pasting
it into this bug report.

I tried also to attach a tar of my jettylauncher source, but sourceforge
won't allow me to because
of it's size. So, Michael, if you can email me from a non-sourceforge
address, I'll send you the
tar.

cheers
Jan

Michael,

I think maybe -p0 would be right, however I'm not sure
that that is the cause of your problem. Also you don't
need to put the patch file into that directory, it can
be anywhere because you can provide the full path to it
with the input redirection on the command line. Again,
I don't think that is necessarily the problem.

I simply did a cvs diff command to get the patch. It seems
it's not nearly as friendly as svn diff  :-( 

Can you see a .classpath file in that jettylauncher directory,
as that is the file it seems to be trying to find to patch.

Have you tried (after having first cd'ed to your jettylauncher
directory): 

 patch -p0 -u < /some/where/com.iw.plugins.jettylauncher.patch

Alternatively I've tar'ed up my jettylauncher directory and attached it 
to this email, if you'd rather do your own diff.

cheers
Jan

Michael Shillinger wrote:
> > Message body follows:
> > 
> > Jan,
> > 
> > I tried to apply your patch to the JettyLauncher source and
> > ran into problems.  I haven't used patch very often and
> > perhaps I am doing it incorrectly
> > 
> > When I run:
> > 
> > patch  -p1 --dry-run  <com.iw.plugins.jettylauncher.patch
> > 
> > I get:
> > 
> > missing header for unified diff at line 11 of patch
> > can't find file to patch at input line 11
> > Perhaps you used the wrong -p or --strip option?
> > The text leading up to this was:
> > --------------------------
> > |? com.iw.plugins.jettylauncher.patch
> > |? com.iw.plugins.jettylauncher_1.1.0.jar
> > |? jettylauncher.jar
> > |Index: .classpath
> > |===================================================================
> > |RCS file:
> > /cvsroot/jettylauncher/com.iw.plugins.jettylauncher/.classpath,v
> > |retrieving revision 1.12
> > |diff -u -r1.12 .classpath
> > |--- .classpath 24 Sep 2004 18:30:06 -0000      1.12
> > |+++ .classpath 21 Jun 2007 08:16:57 -0000
> > --------------------------
> > File to patch: 
> > 
> > The message seems to indicate that my path is not correct. 
> > I think my -p option is correct based on the man page.  I
> > did try -p0, -p2 also.
> > 
> > I have placed the patch file at the top of the jettyLauncher
> > source tree (i.e where the sub-directories include
> > com.iw.plugins.jettylauncher).
> > 
> > My pwd is "/cygdrive/d/dev/jettylauncher" when I execute the
> > patch command.
> > 
> > As you can see, I am using cygwin.
> > 
> > Do you have any ideas??
> > 
> > Thanks
> > Mike Shillinger

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-07-18 20:34

Message:
Logged In: NO 

When does this patch (or any other) gets incorperated?? jetty6 support
(with continuations) in combiniation with the gwt would be very useful for
eclipse!

----------------------------------------------------------------------

Comment By: Jax (ojacquet)
Date: 2007-06-21 15:32

Message:
Logged In: YES 
user_id=1121397
Originator: NO

I'll try to have a look at this this weekend and let you know if it works
for me. Someone else also suggested to include jetty6 in the jettylauncher
release which would make the configuration and maintenance a lot easier.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=682377&aid=1740768&group_id=118870