Re: [Jemacs-info] Implementing eval-last-sexp
Brought to you by:
bothner
From: Shad G. <cap...@gm...> - 2011-04-27 19:20:22
|
Thank you for feedback, Per. I would like to work on this weekend or during my next bout of insomnia, whichever comes first, incorporating your concerns. And I guess I should force myself to take a look at the emacs code. :-) On Tue, Apr 26, 2011 at 9:54 PM, Per Bothner <pe...@bo...> wrote: > > On 04/20/2011 07:44 PM, Shad Gregory wrote: >> >> Hi all, >> >> I'm attempting to implement eval-last-sexp. What I have so far pretty >> much works, >> but there must be some code somewhere in kawa that does the parsing I've >> attempted >> in the method evalLastSexp. > > Well, I'm not sure where in Kawa you'd find a parser that does what > we need. One problem is that it needs to parse *backwards*. And of course > to be correct, you should check if a paren is inside string quotes or > is part of character literal. > > Also note that an sexpr isn't necessary a parenthesis form - it can be > a constant or a symbol. In that case you probably have to scan backwards for > a delimiter. > > So I'm willing to check in your patch as-is (though there are some indentation > issues), it might be a good idea if you could take a look at Emacs's > implementation - see how they do it. We don't need to be 100% correct, but > having a better idea of what Emacs does seems like a good idea. > >> Also, since jemacs supports both kawa and >> elisp, >> should the user be given a way to switch between the two? I've attached >> a diff file >> of my code, any suggestions would be appreciated. > > Yes, perhaps there should be a way to switch languages, but using > the "current language" is probably good enough for now. Regardless, > this may be difficult enough for just one language! > -- > --Per Bothner > pe...@bo... http://per.bothner.com/ |