|
From: Zach D. <zs...@um...> - 2007-03-01 18:39:43
|
Yes, there is quite a bit of duplicate code fragments, not sure why, I'll
blame it on 'cruft'. It may have started out differently :)
On Thu, 1 Mar 2007, Roger Gammans wrote:
> On Wed, Feb 28, 2007 at 10:37:03PM -0500, Zach Del wrote:
> > Nice. Will apply patch to HEAD -- and thanks for the diff.
>
> Glad you like it.
>
> BTW I is there a reason why map.getProvincesMatchingCloset() are
> map.GetProvinceMatching() are implemented seperately, I would
> have thought implementing map.GetProvinceMatching() as
>
> Collection provs=getProvincesMatchingCloset(..);
> if (provs.size()>1) {
> return null;
> } else {
> return provs[0];
> }
>
> would make maintence easier.
>
> TTFN
> --
> Roger. Home| http://www.sandman.uklinux.net/
> Master of Peng Shui. (Ancient oriental art of Penguin Arranging)
> Work|Independent Sys Consultant | http://www.computer-surgery.co.uk/
> New key Fpr: 1227 ABB1 7545 77A7 6816 2D18 4EBC AA9B 8EE3 1DD3
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> jdip-developer mailing list
> jdi...@li...
> https://lists.sourceforge.net/lists/listinfo/jdip-developer
>
>
>
|