Re: [jdee-devel] Bugs introduced that affected jde-import-all

[Paul L. <la...@ma...>]

On Jan 8, 2010, at 2:38 PM, Len Trigg wrote:

> Paul Landes wrote:
>> I found two bugs when using `jde-import-all':
> [...]
>> This all highlights the need for some kind of automated testing.
>> Also, these bugs took many hours to track down and fix so please do
>> some basic testing after making big changes like adding 1.5 parsing
>> cedet code and inner class importing.
>
> I did actually test this patch quite a bit before committing it, which
> is how I found the problem with the wisent 1.5 grammar -- see my
> message on 3 Jan, maybe you missed reading it, it might have saved you
> those hours of debugging.  Without the wisent 1.5 grammar the patch
> worked fine.  I noticed that it did result in a change in behaviour in
> that there was an extra \n between imports and the code, but other
> than that nothing that I would consider a bug.

Yes, spacing is a matter of style.  However, floating and moving  
newline around imports doesn't seem like a feature.

> The main problem seems to be with the wisent 1.5 grammar, and I didn't
> back out that change immediately after my email about it because I was
> hoping that someone more familiar with how jdee and semantic interact
> would investigate and find the solution (in other respects the new
> grammar is much better when dealing with modern Java code).

It would be great if someone was available to do that.  I'd buy them  
dinner.  Until that happens, I suggest we leave this until we upgrade  
to the newest cedet.  I understand it's baked into Emacs 23 (or will  
be in some point release) so perhaps moving to it when it does would  
be the easiest path.

Is there anyone using 23 with JDEE 2.4.0 currently?

Thanks.