Re: [jdee-users] [PATCH 1/2] Factorize minibuffer prompts to read a class name in `jde-read-class-n
Brought to you by:
paullandes
From: <lu...@gn...> - 2009-08-12 09:20:59
|
Paul Landes <la...@ma...> writes: > Ludovic Courtès writes: > > Paul Landes <la...@ma...> writes: > > > > > I appreciate the patch, but there will be functionality in the next > > > release that does a lot of this, including uses `completing-read' as > > > your comment mentions :) > > > > Nice! I didn't find it, in which branch is it? > > Sorry, it isn't in the repository yet. It's in my local stuff I > haven't merged with repository so for you I'm afraid it's vaporware > until I add it. The upshot is won't take long to get it in there. I'd love to see it in the repo, to avoid duplicating work and to know what nice features are going to land in JDEE. ;-) Maybe you could commit it in a separate branch to start with, until you deem it "ready" for trunk/2.4.0? What do you think? > > > Also, the direction I'd like to set is one function for class > > > reading/finding/visiting. Currently we have two, this adds a third. > > > I'd like go keep it at one. > > > > I agree in principle (that was the whole point of this patch: to share > > the read-class-name code between `jde-run' and `jde-debug'), but which > > functions are you referring to? > > - jde-open-class-at-point > - jde-open-class-source Hmm, these functions don't seem to have any connection with the proposed `jde-read-class-name'. `jde-read-class-name' just asks the user for a class name, nothing more, the idea being that code interactively asking for a class name should use it, for the sake of UI consistency. Or did I misunderstand your comment? > > (Before the patch, `jde-run' was doing its own `read-from-minibuffer' > > call, not using any other function.) > > Yes, I know it does a lot of user interfacing. That's on my list of > things to get to. We're on the same track then! Thanks, Ludo'. |