Menu
▾
▴
#90 When expanding Bookmarks to Local Drive "Go Up" doesn't work
I expand the bookmark toolbar twice, first to
"Partitions", then e.g. to "C:\". Then is the "Go up"
button disabled, thus there is no way to come back to
"Partitions" or ROOT. This is because the
Partitionslist is generated dynamically by
OsDynamicBookmarksGenerator.generateContent(). This
functions does not set the parent of the bookmarks --
it can't, it does not know the parent. For bookmarks
without parent, of course the go up button will be
disabled.
The error is probably, that the Drive entries get a
submenu at all. I am investigation this now.
Logged In: YES
user_id=1473670
Ok, the problem is that DefaultBookmarks (which are what
OsDynamicBookmarksGenerator uses) are implementated to have
isgroup()==true. There are two possibilities: Either we
change to an implemented isgroup()==false, which would make
org.jcommander.ui.filepanel.bookmarks.Tester unable to work,
or we introduce a new private boolean group with getter and
setter. What do you think?
Logged In: YES
user_id=940779
This bug was introduced by the migration to VFS.
I think the private boolean member would be the better
choice since a similar solution was used in the version
prior to VFS. Could you take care of this?
Logged In: YES
user_id=1473670
Of course, you are welcome. The fix is submitted.
Logged In: YES
user_id=940779
Great!