[Jboss-dev-forums] [Design of Mail Services] - Protocol Configuration Changes.

[mikezzz <nu...@jb...>]

Hi,

I have completed (but not commited) some changes to remove the SMTPProcotocol/POPProtocol.setProperties() and replace it with standard MBean attributes for each property.  I have held off committing right now as the change is bigish.  Also Andy will probably want to hit me as it will mean changes to his Velocity templates for izPack.  However I have made the necessary updates to the default jboss-service.xml and the unit tests also pass.  The getProperty/getPropertyBool/getPropertyLong methods still exist and are still used, but instead they read the properties using MBeanServer.getAttribute.  The SMTPConstants also changed to use MBean property names.
 
However I would like to get these changes in.  The reasons for the change are:

- More type safe.
- Makes it easier to change individual properties from code.  This is useful for testing where tests use different properties, only have to set the necessary ones and not supply a full configuration for each test (Unit tests for JBMAIL-16 really would like this).
- Removes a total of ~200 lines of code from SMTPProtocol/POPProtocol.
- Makes it easier to manage individual properties for the Protocols via JMX-Console.

If there are no serious objections, I will commit this in the next couple of days.  

Mike.

P.S.  Andy I am happy to help out fixing the templates if required.

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3887526#3887526

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3887526