[JBoss-dev] [ jboss-Bugs-755915 ] thread housekeeping in rar deployment

[SourceForge.net <no...@so...>]

Bugs item #755915, was opened at 2003-06-17 13:43
Message generated for change (Settings changed) made by d_jencks
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=755915&group_id=22866

Category: JBossServer
Group: v3.2
Status: Open
Resolution: None
Priority: 5
Submitted By: Rod Burgett (rodburgett)
>Assigned to: David Jencks (d_jencks)
Summary: thread housekeeping in rar deployment

Initial Comment:
The IdleRemover and PoolFiller classes in the 
org.jboss.resource.connectionmanager package each 
creates a Thread to perform it's job.  Neither Thread is 
terminated gracefully at shutdown, they continue until 
all non-daemon threads terminate.

There are diff files attached for modifications to 
terminate the threads when the RARDeployer is stopped.

The IdleRemover32.diff file contains an update to add a 
public shutdown() method to the class.  The new 
method simply invokes the existing stop method on the 
remover field.

The PoolFiller32.diff file contains updates to add a similar 
public shutdown() method to the class.  The new 
method simply invokes a new stop method on the 
remover field.  The new stop method interrupts the 
fillerThread, in a fashion very similar to IdelRemover.  
Two additional updates are included for this class: the 
addition of a Logger, and message logging as the thread 
is terminated.

The RARDeployer32.diff file contains updates to make 
use of the new shutdown methods in the other classes.  
A stopService method was added to perform some local 
cleanup:

 - invoke super.stopService
 - shut down the IdleRemover and PoolFiller threads
 - null out the service controller field

Also, in the destroy method of the RARDeployer, the 
order of two commands was reversed. super.destroy 
should be called before the class loader of the 
deployment info instance is nulled, since there's no 
guarantee that the class loader won't be used by some 
other destroy method in the inheritance chain.



----------------------------------------------------------------------

Comment By: Rod Burgett (rodburgett)
Date: 2003-06-17 13:46

Message:
Logged In: YES 
user_id=681969

adding the last diff file...

----------------------------------------------------------------------

Comment By: Rod Burgett (rodburgett)
Date: 2003-06-17 13:45

Message:
Logged In: YES 
user_id=681969

uploading another diff file...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=376685&aid=755915&group_id=22866